{{ message }}
Repository navigation
refactor(docs-infra): change class to interface where class properties not used - #36958
Closed
ajitsinghkaler wants to merge 1 commit into
Closed
ajitsinghkaler wants to merge 1 commit into
ajitsinghkaler wants to merge 1 commit into
Conversation
ajitsinghkaler
force-pushed
the
interface-changes
branch
3 times, most recently
from
May 7, 2020 01:25
b7544f1 to
6c3d3c1
Compare
ajitsinghkaler
changed the title
gkalpak
changed the title
gkalpak
added
comp: docs-infra
action: cleanup
gkalpak
approved these changes
May 7, 2020
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
Thx, @ajitsinghkaler!
Can you please change the commit message to refactor(docs-infra): ...?
…s not used In resource.model.ts the interfaces of the resources were defined as classes, these do not use any class properties and are only used for type checking. So, changed them from class to interface.
ajitsinghkaler
force-pushed
the
interface-changes
branch
from
May 7, 2020 14:39
6c3d3c1 to
fda33cc
Compare
Contributor
Author
gkalpak
added
action: merge
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…s not used (angular#36958) In resource.model.ts the interfaces of the resources were defined as classes, these do not use any class properties and are only used for type checking. So, changed them from class to interface. PR Close angular#36958
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In resource.model.ts the interfaces of the resources were defined as classes, these do not use any class properties and are only used for type checking. So, changed them from class to interface.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
class used for interfaces
Issue Number: N/A
What is the new behavior?
Interface used for interfaces
Does this PR introduce a breaking change?
Other information