ci: increase AIO payload size limit by AndrewKushnir · Pull Request #35702 · angular/angular · GitHub
Skip to content

ci: increase AIO payload size limit - #35702

Closed
AndrewKushnir wants to merge 1 commit into
angular:masterfrom
AndrewKushnir:aio_payload_update_0226
Closed

AndrewKushnir wants to merge 1 commit into
angular:masterfrom
AndrewKushnir:aio_payload_update_0226

Conversation

@AndrewKushnir

@AndrewKushnir AndrewKushnir commented Feb 26, 2020 •

Copy link
Copy Markdown
Contributor

This commit updates AIO payload size limit that is triggering a problem after merging 0bc35a7. That commit added some payload size, but all checks were "green" for the original PR (#34574), so it looks like it's an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master branch back to "green" state.

Note: for some reasons patch branch is not affected (which might indicate that there is a discrepancy between branches), but I think we should update both master and patch to keep limits consistent.

PR Type

What kind of change does this PR introduce?

  • CI related changes

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 26, 2020
@ngbot ngbot Bot modified the milestone: needsTriage Feb 26, 2020
This commit updates AIO payload size limit that is triggering a problem after merging angular@0bc35a7. That commit added some payload size, but all checks were "green" for the original PR (angular#34574), so it looks like it's an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master branch back to "green" state.
@AndrewKushnir
AndrewKushnir force-pushed the aio_payload_update_0226 branch from 1bb2a75 to ec9f84a Compare February 26, 2020 23:57

@kara kara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 26, 2020
@AndrewKushnir
AndrewKushnir removed the request for review from petebacondarwin February 27, 2020 00:06
atscott pushed a commit that referenced this pull request Feb 27, 2020
This commit updates AIO payload size limit that is triggering a problem after merging 0bc35a7. That commit added some payload size, but all checks were "green" for the original PR (#34574), so it looks like it's an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master branch back to "green" state.

PR Close #35702
@atscott atscott closed this in 91934eb Feb 27, 2020
gkalpak added a commit to ajitsinghkaler/angular that referenced this pull request Feb 27, 2020
In angular#35702, the payload size limit for Ivy builds was bumped to account
for small incremental increases in recent PRs. The ViewEngine size has
also increased similarly (~500B), but it was not updated in angular#35702,
because its total increase was just below the 500B error threshold (by
6B).

This commit bumps the ViewEngine size limit too.

Note: Any investigation for the Ivy size increase (as a follow-up
to angular#35702) will most likely also apply to ViewEngine, since the size was
increased by the same amount.
atscott pushed a commit that referenced this pull request Feb 27, 2020
In #35702, the payload size limit for Ivy builds was bumped to account
for small incremental increases in recent PRs. The ViewEngine size has
also increased similarly (~500B), but it was not updated in #35702,
because its total increase was just below the 500B error threshold (by
6B).

This commit bumps the ViewEngine size limit too.

Note: Any investigation for the Ivy size increase (as a follow-up
to #35702) will most likely also apply to ViewEngine, since the size was
increased by the same amount.

PR Close #34978
atscott pushed a commit that referenced this pull request Feb 27, 2020
In #35702, the payload size limit for Ivy builds was bumped to account
for small incremental increases in recent PRs. The ViewEngine size has
also increased similarly (~500B), but it was not updated in #35702,
because its total increase was just below the 500B error threshold (by
6B).

This commit bumps the ViewEngine size limit too.

Note: Any investigation for the Ivy size increase (as a follow-up
to #35702) will most likely also apply to ViewEngine, since the size was
increased by the same amount.

PR Close #34978
@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants