{{ message }}
Repository navigation
ci: increase AIO payload size limit - #35702
Closed
AndrewKushnir wants to merge 1 commit into
Closed
AndrewKushnir wants to merge 1 commit into
AndrewKushnir wants to merge 1 commit into
Conversation
This commit updates AIO payload size limit that is triggering a problem after merging angular@0bc35a7. That commit added some payload size, but all checks were "green" for the original PR (angular#34574), so it looks like it's an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master branch back to "green" state.
AndrewKushnir
force-pushed
the
aio_payload_update_0226
branch
from
February 26, 2020 23:57
1bb2a75 to
ec9f84a
Compare
2 of 12 tasks
atscott
pushed a commit
that referenced
this pull request
Feb 27, 2020
This commit updates AIO payload size limit that is triggering a problem after merging 0bc35a7. That commit added some payload size, but all checks were "green" for the original PR (#34574), so it looks like it's an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master branch back to "green" state. PR Close #35702
gkalpak
added a commit
to ajitsinghkaler/angular
that referenced
this pull request
Feb 27, 2020
In angular#35702, the payload size limit for Ivy builds was bumped to account for small incremental increases in recent PRs. The ViewEngine size has also increased similarly (~500B), but it was not updated in angular#35702, because its total increase was just below the 500B error threshold (by 6B). This commit bumps the ViewEngine size limit too. Note: Any investigation for the Ivy size increase (as a follow-up to angular#35702) will most likely also apply to ViewEngine, since the size was increased by the same amount.
atscott
pushed a commit
that referenced
this pull request
Feb 27, 2020
In #35702, the payload size limit for Ivy builds was bumped to account for small incremental increases in recent PRs. The ViewEngine size has also increased similarly (~500B), but it was not updated in #35702, because its total increase was just below the 500B error threshold (by 6B). This commit bumps the ViewEngine size limit too. Note: Any investigation for the Ivy size increase (as a follow-up to #35702) will most likely also apply to ViewEngine, since the size was increased by the same amount. PR Close #34978
atscott
pushed a commit
that referenced
this pull request
Feb 27, 2020
In #35702, the payload size limit for Ivy builds was bumped to account for small incremental increases in recent PRs. The ViewEngine size has also increased similarly (~500B), but it was not updated in #35702, because its total increase was just below the 500B error threshold (by 6B). This commit bumps the ViewEngine size limit too. Note: Any investigation for the Ivy size increase (as a follow-up to #35702) will most likely also apply to ViewEngine, since the size was increased by the same amount. PR Close #34978
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This commit updates AIO payload size limit that is triggering a problem after merging 0bc35a7. That commit added some payload size, but all checks were "green" for the original PR (#34574), so it looks like it's an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master branch back to "green" state.
Note: for some reasons patch branch is not affected (which might indicate that there is a discrepancy between branches), but I think we should update both master and patch to keep limits consistent.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?