{{ message }}
Repository navigation
docs: update aot compiler docs - #35487
Closed
santoshyadavdev wants to merge 1 commit into
Closed
santoshyadavdev wants to merge 1 commit into
santoshyadavdev wants to merge 1 commit into
Conversation
santoshyadavdev
force-pushed
the
docs--update-aot-compiler-docs
branch
from
February 17, 2020 09:20
096f4ed to
ff20d89
Compare
Contributor
Author
kapunahelewong
left a comment
kapunahelewong
left a comment
Contributor
There was a problem hiding this comment.
One small suggestion. We'll still need engineering to review.
Contributor
There was a problem hiding this comment.
Suggested change
| * **_Just-in-Time_ (JIT)**, was used as default till Angular 8. | |
| * **_Just-in-Time_ (JIT)**, was used as default until Angular 8. |
AndrewKushnir
approved these changes
Feb 19, 2020
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @santoshyadav198613, the change LGTM 👍
santoshyadavdev
force-pushed
the
docs--update-aot-compiler-docs
branch
from
February 20, 2020 09:08
ff20d89 to
ad447e6
Compare
Contributor
Author
|
Hi @kapunahelewong , |
gkalpak
reviewed
Apr 18, 2020
kapunahelewong
approved these changes
Apr 20, 2020
santoshyadavdev
force-pushed
the
docs--update-aot-compiler-docs
branch
2 times, most recently
from
April 22, 2020 06:40
09a44aa to
2ac3b03
Compare
Contributor
Author
|
Hi @gkalpak , |
gkalpak
suggested changes
Apr 22, 2020
Comment on lines
46
to
47
Member
There was a problem hiding this comment.
This change looks strange. For JIT we mention when it was the default and for AOT we mention what it does 😃
How about:
Suggested change
| * **_Just-in-Time_ (JIT)**, was used as default until Angular 8. | |
| * **_Ahead-of-Time_ (AOT)**, which compiles your app and libraries at build time. | |
| * **_Just-in-Time_ (JIT)**, which compiles your app in the browser at runtime. This was the default until Angular 8. | |
| * **_Ahead-of-Time_ (AOT)**, which compiles your app and libraries at build time. This is the default since Angular 9. |
Contributor
Author
There was a problem hiding this comment.
sure looks good to me as well
santoshyadavdev
force-pushed
the
docs--update-aot-compiler-docs
branch
2 times, most recently
from
April 29, 2020 13:52
d024ece to
1ba8c92
Compare
Contributor
Author
|
Done with the changes @gkalpak |
Contributor
Author
|
I can see lint error |
santoshyadavdev
force-pushed
the
docs--update-aot-compiler-docs
branch
from
May 1, 2020 15:30
1ba8c92 to
86da9dc
Compare
change to aot docs to include changes after angular 9 aot is true for new applications created, also it will be updated to aot true once app is updated using ng update
santoshyadavdev
force-pushed
the
docs--update-aot-compiler-docs
branch
from
May 2, 2020 03:21
86da9dc to
f8e7176
Compare
Contributor
Author
|
Hi @gkalpak , |
gkalpak
approved these changes
May 8, 2020
Member
|
Thx, @santoshyadav198613! |
gkalpak
added
action: merge
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
change to aot docs to include changes after angular 9 aot is true for new applications created, also it will be updated to aot true once app is updated using ng update PR Close #35487
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
change to aot docs to include changes after angular 9 aot is true for new applications created, also it will be updated to aot true once app is updated using ng update PR Close angular#35487
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35415
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #35415
What is the new behavior?
Does this PR introduce a breaking change?
Other information