Log tags need to be shorter than 24 chars according to android docume… · Pull Request #1739 · androidannotations/androidannotations · GitHub
Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Log tags need to be shorter than 24 chars according to android docume…#1739

Closed
ghost wants to merge 3 commits into
developfrom
unknown repository
Closed

Log tags need to be shorter than 24 chars according to android docume…#1739
ghost wants to merge 3 commits into
developfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 30, 2016

Copy link
Copy Markdown

@WonderCsabo

Copy link
Copy Markdown
Member

@ghost

ghost commented Mar 30, 2016

Copy link
Copy Markdown
Author

@WonderCsabo bump

@WonderCsabo

Copy link
Copy Markdown
Member

Thanks! Can i ask you to:

  • fix the header in the new class (the build is failed because of that)
  • please reword your commit messages per the contributor guide in the wiki
  • add an overload to the log helper method, which accepts a GeneratedClassHolder (so we can remove more code duplication)
  • squash the last commits

@WonderCsabo

Copy link
Copy Markdown
Member

@dodgex dodgex mentioned this pull request Jun 1, 2016
@WonderCsabo WonderCsabo closed this Jun 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants