{{ message }}
improvement : exceptions with error description message#11
Open
g-raffy wants to merge 1 commit into
Open
Conversation
…essage detailing the reason of the failure is displayed
Owner
Author
|
Hi again Andreas (and thanks for your gco_python project, by the way!), |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I made some modifications so that from now on, whenever an exception is raised in the graph cut c++ code, the message detailing the reason of the failure is displayed (graph-cut c++ exceptions are translated into python exceptions).
Without this change, whenever the graph code fails, a c++ exception (with a message detailing the reason of failure) is raised, but the description of the error is lost when translated into python exception: as a result, the user has no message to help him to understand why graph cut optimization failed.