{{ message }}
Upload sdist to PYPI as well#445
Merged
Merged
Conversation
Collaborator
Author
|
Updated with better naming and a test for sdist install. The test is modeled after existing wheel test, but is non-blocking |
Collaborator
Author
popematt
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, source isn't published to PYPI; this is a regression: compare 0.14.5 files and 0.13.0 files, the latter has source distribution, the former does not.
The source distribution is built under
sourcename, see, e.g. 0.14.5 release artifacts. It is NOT used in the publishing step, because this step explicitly downloads onlywheel-8artifacts:ion-python/.github/workflows/release.yml
Line 129 in a2a13c7
This PR changes artifact naming so that sdist is downloaded in the publishing step and published to PYPI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.