chore(plugin-testops): support `enable` property from config by formaceft-93 · Pull Request #721 · allure-framework/allure3 · GitHub
Skip to content

chore(plugin-testops): support enable property from config#721

Merged
vdvukhzhilov merged 3 commits into
mainfrom
pass-enabled-plugins
Jun 22, 2026
Merged

chore(plugin-testops): support enable property from config#721
vdvukhzhilov merged 3 commits into
mainfrom
pass-enabled-plugins

Conversation

@formaceft-93

@formaceft-93 formaceft-93 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

The config resolver now passes the resolved plugin enabled state into plugin constructors, so enabled defaults are handled consistently.

@formaceft-93 formaceft-93 added the type:bug Something isn't working label Jun 19, 2026
@formaceft-93 formaceft-93 force-pushed the pass-enabled-plugins branch from feaa648 to 1df2811 Compare June 19, 2026 16:05
vdvukhzhilov
vdvukhzhilov reviewed Jun 19, 2026
View reviewed changes
Comment thread packages/plugin-testops/src/plugin.ts
vdvukhzhilov
vdvukhzhilov requested changes Jun 19, 2026
View reviewed changes

@vdvukhzhilov vdvukhzhilov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like if enabled is not passed in config, the plugin will run locally anyways. And this is not desired.

@github-actions

github-actions Bot commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Allure perf metrics

Generated at: 2026-06-22T14:24:30.203Z

Phase Count Total Avg Min Max
restoreState.total 1 2751.2 ms 2751.2 ms 2751.2 ms 2751.2 ms
restoreState.dump 3 2750.6 ms 916.9 ms 861.2 ms 971.1 ms
restoreState.attachments 3 2213.8 ms 737.9 ms 697.4 ms 758.6 ms
restoreState.storeRestore 3 161.8 ms 53.9 ms 47.0 ms 63.8 ms
generate.total 1 729801.7 ms 729801.7 ms 729801.7 ms 729801.7 ms
generate.plugins.done 1 8821.3 ms 8821.3 ms 8821.3 ms 8821.3 ms
publish.upload.total 1 428983.1 ms 428983.1 ms 428983.1 ms 428983.1 ms
summary.generate 2 14.8 ms 7.4 ms 7.3 ms 7.5 ms
generate.plugin.done.agent 1 0.2 ms 0.2 ms 0.2 ms 0.2 ms
generate.plugin.done.awesome 1 7137.8 ms 7137.8 ms 7137.8 ms 7137.8 ms
generate.plugin.done.dashboard 1 981.3 ms 981.3 ms 981.3 ms 981.3 ms
generate.plugin.done.log 1 3.0 ms 3.0 ms 3.0 ms 3.0 ms
generate.plugin.done.testops 1 698.4 ms 698.4 ms 698.4 ms 698.4 ms
publish.upload.plugin.awesome 1 420014.8 ms 420014.8 ms 420014.8 ms 420014.8 ms
publish.upload.plugin.dashboard 1 2082.5 ms 2082.5 ms 2082.5 ms 2082.5 ms

Artifacts: allure-perf-metrics

@formaceft-93 formaceft-93 force-pushed the pass-enabled-plugins branch from cdc347a to d61c3bf Compare June 22, 2026 13:26
@vdvukhzhilov vdvukhzhilov changed the title fix testops plugin chore(plugin-testops): support enable property from config Jun 22, 2026
@vdvukhzhilov vdvukhzhilov added type:improvement New feature or request and removed type:bug Something isn't working labels Jun 22, 2026
@vdvukhzhilov vdvukhzhilov merged commit 4ecfcd8 into main Jun 22, 2026
13 checks passed
@vdvukhzhilov vdvukhzhilov deleted the pass-enabled-plugins branch June 22, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdvukhzhilov vdvukhzhilov vdvukhzhilov approved these changes

Assignees

No one assigned

Labels

theme:testops type:improvement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@formaceft-93 @vdvukhzhilov