iframe-proxy

pawbtism · 2025-05-30T02:48:23Z

Description

resolves #870 and changes snippet behavior to reply to the command

Guidelines

My code follows the style guidelines of this project (formatted with Ruff)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if needed
My changes generate no new warnings
I have tested this change
Any dependent changes have been merged and published in downstream modules
I have added all appropriate labels to this PR
I have followed all of these guidelines.

How Has This Been Tested? (if applicable)

locally hosted and tested in ATL's dev server

Summary by Sourcery

Enhancements:

Change snippet command to reply to the invoking or referenced message instead of sending a standalone message.

sourcery-ai · 2025-05-30T02:48:29Z

Reviewer's Guide

Modified the snippet command to reply contextually rather than broadcasting via ctx.send: it inspects message references and uses Message.reply or ctx.reply accordingly, preserving allowed_mentions and falling back if no reference exists.

Sequence Diagram: Snippet Command Reply Behavior

sequenceDiagram
    actor User
    participant Bot

    User->>Bot: Executes snippet command (e.g., /snippet name)
    activate Bot
    Bot->>Bot: Retrieves snippet text
    alt Command is a reply to an existing message
        participant RepliedMessage as "Message User Replied To"
        Bot->>Bot: Detects command is a reply to RepliedMessage
        Bot->>Bot: resolved_reference = RepliedMessage
        Bot-->>RepliedMessage: reply(snippet_text)
    else Command is not a reply or reference is not a message
        participant CommandMessage as "User's Command Message"
        Bot->>Bot: No valid message reference found
        Bot-->>CommandMessage: reply(snippet_text) to user's command
    end
    deactivate Bot

File-Level Changes

Change	Details	Files
Replace generic send with contextual reply logic	Removed direct ctx.send invocation Added check for ctx.message.reference and its resolved target Branch to reply to the referenced message if it’s a Message Fallback to ctx.reply when no valid reference is present	`tux/cogs/snippets/get_snippet.py`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#870	When a snippet command is invoked as a reply to a message, the snippet response should also reply to that message.	✅

Possibly linked issues

Add reply to snippets #870: The PR changes snippet behavior to reply to the command, implementing the feature requested in the issue.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @CapnRyna - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟡 General issues: 2 issues found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

HikariNee

Looks good.

jakobdylanc · 2025-06-01T12:07:48Z

tux/tux/cogs/snippets/get_snippet.py

Lines 80 to 91 in 4b07ab0

    
           # pagination if text > 2000 characters 
        
           if len(text) <= 2000: 
        
               # Check if there is a message being replied to 
        
               if ctx.message.reference and ctx.message.reference.resolved: 
        
                   reference = ctx.message.reference.resolved 
        
                   if isinstance(reference, Message): 
        
                       await reference.reply(text, allowed_mentions=AllowedMentions.none()) 
        
                   else: 
        
                       await ctx.reply(text, allowed_mentions=AllowedMentions.none()) 
        
               else: 
        
                   await ctx.reply(text, allowed_mentions=AllowedMentions.none()) 
        
               return

This can be simplified to just:

# pagination if text > 2000 characters
if len(text) <= 2000:
    # Check if there is a message being replied to
    reference = getattr(ctx.message.reference, "resolved", None)
    reply_target = reference if isinstance(reference, Message) else ctx

    await reply_target.reply(text, allowed_mentions=AllowedMentions.none())
    return

anemoijereja-eden · 2025-06-01T18:36:25Z

pawbtism added 3 commits May 29, 2025 22:25

feat(snippets): added reply reference to snippets

9363b98

added comment

ef90d23

change send to reply

4b07ab0

sourcery-ai Bot reviewed May 30, 2025

View reviewed changes

Comment thread tux/cogs/snippets/get_snippet.py Outdated

Comment thread tux/cogs/snippets/get_snippet.py Outdated

HikariNee approved these changes Jun 1, 2025

View reviewed changes

simplified check, thanks jakob!

e48d02e

anemoijereja-eden merged commit 43c1e05 into allthingslinux:main Jun 1, 2025
1 check passed

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(snippets): change snippet command behavior#875

feat(snippets): change snippet command behavior#875
anemoijereja-eden merged 4 commits into
allthingslinux:mainfrom
pawbtism:reply-snippet

pawbtism commented May 30, 2025 •

edited by sourcery-ai Bot

Loading

Uh oh!

sourcery-ai Bot commented May 30, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

HikariNee left a comment

Uh oh!

jakobdylanc commented Jun 1, 2025 •

edited

Loading

Uh oh!

anemoijereja-eden commented Jun 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

pawbtism commented May 30, 2025 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Guidelines

How Has This Been Tested? (if applicable)

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Sequence Diagram: Snippet Command Reply Behavior

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

HikariNee left a comment

Choose a reason for hiding this comment

Uh oh!

jakobdylanc commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anemoijereja-eden commented Jun 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pawbtism commented May 30, 2025 •

edited by sourcery-ai Bot

Loading

sourcery-ai Bot commented May 30, 2025 •

edited

Loading

jakobdylanc commented Jun 1, 2025 •

edited

Loading