{{ message }}
Adding sendMessage and getWebsocket methods to RTM client#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Reason for adding sendMessage method- Today, I don't see a way to reply back slack (bot) using webSocket if you're connected using Slack RTM api, because of this, as a workaround i'm creating a SlackWebApiClient and using postMessage web api to send messages to Slack. So using the new sendMessage method I can avoid going for workaround and stick to RTM api alone.
Reason for adding getWebsocket method: I'm making the webSocket visible outside of SlackRealTimeMessagingClient, just to make use of the webSocket and others method provided by it apart from sendMessage.
Please go through the pull request and let me know if i'm missing something...Cheers!!