fix(sql engine): misused group_count/group_topk by JalinWang · Pull Request #531 · alibaba/zvec · GitHub
Skip to content

fix(sql engine): misused group_count/group_topk#531

Open
JalinWang wants to merge 1 commit into
alibaba:mainfrom
JalinWang:fix/sql-engine-group-results
Open

fix(sql engine): misused group_count/group_topk#531
JalinWang wants to merge 1 commit into
alibaba:mainfrom
JalinWang:fix/sql-engine-group-results

Conversation

@JalinWang

Copy link
Copy Markdown
Collaborator

group_count represents the number of groups to return, not the number of documents per group, while group_topk represents the number of documents per group.

@egolearner egolearner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants