feat(dictionaries): adds methods and tests by chloelbn · Pull Request #1253 · algolia/algoliasearch-client-javascript · GitHub
Skip to content

feat(dictionaries): adds methods and tests#1253

Merged
Haroenv merged 16 commits into
masterfrom
feat/custom-dictionaries
Apr 13, 2021
Merged

feat(dictionaries): adds methods and tests#1253
Haroenv merged 16 commits into
masterfrom
feat/custom-dictionaries

Conversation

@chloelbn

Copy link
Copy Markdown

Fixes #1248

@chloelbn chloelbn requested a review from Haroenv February 17, 2021 10:20
@chloelbn chloelbn marked this pull request as draft February 17, 2021 10:20
Comment thread packages/algoliasearch/src/builds/node.ts Outdated
Comment thread packages/client-common/src/__tests__/TestSuite.ts Outdated
@chloelbn chloelbn force-pushed the feat/custom-dictionaries branch from 9f732b4 to 0b9c2c0 Compare February 17, 2021 10:24
@codesandbox-ci

Copy link
Copy Markdown

@codesandbox-ci

codesandbox-ci Bot commented Feb 17, 2021

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb5a73f:

Sandbox Source
javascript-client-app Configuration

@chloelbn chloelbn force-pushed the feat/custom-dictionaries branch from 0b9c2c0 to 8f648ad Compare February 17, 2021 13:37
@Haroenv

Haroenv commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

@Haroenv Haroenv marked this pull request as ready for review April 12, 2021 13:39

@Haroenv Haroenv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @shortcuts for finalising this!

Comment thread packages/client-search/src/types/GetDictionarySettingsResponse.ts Outdated
Comment thread packages/client-search/src/types/SaveDictionaryEntriesOptions.ts Outdated
Comment thread packages/client-search/src/__tests__/integration/dictionary.test.ts Outdated

@Haroenv Haroenv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green!

@Haroenv Haroenv merged commit aed6554 into master Apr 13, 2021
@Haroenv Haroenv deleted the feat/custom-dictionaries branch April 13, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(feat): Custom Dictionaries

3 participants