feat(ts): add virtual index parameters by Haroenv · Pull Request #1251 · algolia/algoliasearch-client-javascript · GitHub
Skip to content

feat(ts): add virtual index parameters#1251

Merged
Haroenv merged 5 commits into
masterfrom
feat/virtual-index
Feb 8, 2021
Merged

feat(ts): add virtual index parameters#1251
Haroenv merged 5 commits into
masterfrom
feat/virtual-index

Conversation

@Haroenv

@Haroenv Haroenv commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

fixes #1249

@codesandbox-ci

codesandbox-ci Bot commented Feb 3, 2021 •
edited
Loading

Copy link
Copy Markdown

Haroenv
Haroenv commented Feb 4, 2021
View reviewed changes
Comment thread packages/client-search/src/types/Settings.ts
@Haroenv Haroenv requested a review from Ant-hem February 4, 2021 08:19
samouss
samouss reviewed Feb 4, 2021
View reviewed changes
Comment thread packages/client-search/src/types/SearchResponse.ts Outdated
Ant-hem
Ant-hem reviewed Feb 4, 2021
View reviewed changes
Comment thread packages/client-search/src/types/SearchResponse.ts Outdated
Ant-hem
Ant-hem reviewed Feb 4, 2021
View reviewed changes
Comment thread packages/client-search/src/types/SearchResponse.ts Outdated
Ant-hem
Ant-hem reviewed Feb 4, 2021
View reviewed changes
Comment thread packages/client-search/src/types/SearchOptions.ts Outdated
Ant-hem
Ant-hem reviewed Feb 4, 2021
View reviewed changes
Comment thread packages/client-search/src/types/Settings.ts Outdated
@Haroenv @Ant-hem
Apply suggestions from code review
290ce12 
Co-authored-by: Antoine Hémery <antoine.hemery@algolia.com>
@Haroenv Haroenv requested review from Ant-hem and samouss February 4, 2021 12:43
@Haroenv

Haroenv commented Feb 4, 2021

Copy link
Copy Markdown
Contributor Author

Ant-hem
Ant-hem reviewed Feb 4, 2021
View reviewed changes
Comment thread packages/client-search/src/types/SearchResponse.ts Outdated
Ant-hem
Ant-hem approved these changes Feb 4, 2021
View reviewed changes

@Ant-hem Ant-hem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haroenv Haroenv merged commit cffd8f0 into master Feb 8, 2021
@Haroenv Haroenv deleted the feat/virtual-index branch February 8, 2021 12:39
@Haroenv Haroenv mentioned this pull request Feb 9, 2021
Merged
This was referenced Mar 10, 2021
Closed
Closed
Closed
Merged
Open
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ant-hem Ant-hem Ant-hem approved these changes
@chloelbn chloelbn Awaiting requested review from chloelbn
@VladislavFitz VladislavFitz Awaiting requested review from VladislavFitz
@samouss samouss Awaiting requested review from samouss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(virtual indices): Virtual indices related parameters

3 participants

@Haroenv @samouss @Ant-hem