Fix secure shared cookie by Dreamsorcerer · Pull Request #13830 · aio-libs/aiohttp · GitHub
Skip to content

Fix secure shared cookie - #13830

Merged
Dreamsorcerer merged 5 commits into
masterfrom
fix-shared-secure-cookie
Sep 27, 2026
Merged

Fix secure shared cookie#13830
Dreamsorcerer merged 5 commits into
masterfrom
fix-shared-secure-cookie

Conversation

@Dreamsorcerer

@Dreamsorcerer Dreamsorcerer commented Sep 27, 2026

Copy link
Copy Markdown
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot labels Sep 27, 2026
@pyba-chronographer pyba-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Sep 27, 2026
@codecov

codecov Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown

@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Critical risk] Fixes secure cookie handling in HTTP requests.

No outstanding findings block merging.

Reviews (2) · Last reviewed commit: "Merge branch 'master' into fix-shared-se..."

greptile-apps[bot]
greptile-apps Bot reviewed Sep 27, 2026
View reviewed changes
Comment thread docs/client_reference.rst
@greptile-apps

This comment has been minimized.

Sign in to view
@codspeed

codspeed Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 97 untouched benchmarks
⏩ 83 skipped benchmarks1

Comparing fix-shared-secure-cookie (9de50d7) with master (25f3057)

Open in CodSpeed

Footnotes

  1. 83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dreamsorcerer
Dreamsorcerer merged commit e11d283 into master Sep 27, 2026
57 checks passed
@Dreamsorcerer
Dreamsorcerer deleted the fix-shared-secure-cookie branch September 27, 2026 19:37
@patchback

patchback Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport to 3.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.15/e11d2836203a21bec59095498e578d37801027e7/pr-13830

Backported as #13831

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback Bot mentioned this pull request Sep 27, 2026
Merged
@patchback

patchback Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@patchback patchback Bot mentioned this pull request Sep 27, 2026
Merged
Dreamsorcerer added a commit that referenced this pull request Sep 27, 2026
@patchback @Dreamsorcerer
[PR #13830/e11d2836 backport][3.15] Fix secure shared cookie (#13831)
731f7ef 
**This is a backport of PR #13830 as merged into master
(e11d283).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Sep 27, 2026
@patchback @Dreamsorcerer
[PR #13830/e11d2836 backport][3.14] Fix secure shared cookie (#13832)
999c356 
**This is a backport of PR #13830 as merged into master
(e11d283).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dreamsorcerer