Use protocol scheme for absolute-form requests by Dreamsorcerer · Pull Request #13821 · aio-libs/aiohttp · GitHub
Skip to content

Use protocol scheme for absolute-form requests - #13821

Merged
Dreamsorcerer merged 9 commits into
masterfrom
absolute-scheme
Sep 27, 2026
Merged

Dreamsorcerer merged 9 commits into
masterfrom
absolute-scheme

Conversation

@Dreamsorcerer

Copy link
Copy Markdown
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot labels Sep 26, 2026
@pyba-chronographer pyba-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Sep 26, 2026
@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

@greptile-apps

greptile-apps Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Critical risk] Changes how the web server validates and interprets request URLs.

No outstanding findings block merging.

Reviews (5) · Last reviewed commit: "Apply suggestion from @Dreamsorcerer"

Comment thread aiohttp/web_request.py Outdated
@codspeed

codspeed Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 97 untouched benchmarks
⏩ 83 skipped benchmarks1


Comparing absolute-scheme (dd808d6) with master (040c65e)

Open in CodSpeed

Footnotes

  1. 83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dreamsorcerer Dreamsorcerer changed the title Use protocol scheme for abosolute-form requests Use protocol scheme for absolute-form requests Sep 26, 2026
Comment thread aiohttp/http_parser.py Outdated
@Dreamsorcerer
Dreamsorcerer merged commit a921cfd into master Sep 27, 2026
57 checks passed
@Dreamsorcerer
Dreamsorcerer deleted the absolute-scheme branch September 27, 2026 16:21
@patchback

patchback Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Backport to 3.15: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply a921cfd on top of patchback/backports/3.15/a921cfd0fec28d5a9e5bf8d6f4372b8fa63c49df/pr-13821

Backporting merged PR #13821 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    git remote add upstream https://github.com/aio-libs/aiohttp.git
    
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    git fetch upstream
    git checkout -b patchback/backports/3.15/a921cfd0fec28d5a9e5bf8d6f4372b8fa63c49df/pr-13821 upstream/3.15
    
  4. Now, cherry-pick PR Use protocol scheme for absolute-form requests #13821 contents into that branch:
    git cherry-pick -x a921cfd0fec28d5a9e5bf8d6f4372b8fa63c49df
    
    If it'll yell at you with something like fatal: Commit a921cfd0fec28d5a9e5bf8d6f4372b8fa63c49df is a merge but no -m option was given., add -m 1 as follows instead:
    git cherry-pick -m1 -x a921cfd0fec28d5a9e5bf8d6f4372b8fa63c49df
    
  5. At this point, you'll encounter some merge conflicts. You must
    resolve them in order to preserve the patch from PR Use protocol scheme for absolute-form requests #13821 as close to the
    original as possible.
  6. Once conflicts are resolved and git added, run:
    git cherry-pick --continue
    
  7. Push this branch to your fork on GitHub:
    git push origin patchback/backports/3.15/a921cfd0fec28d5a9e5bf8d6f4372b8fa63c49df/pr-13821
    
  8. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback

patchback Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Dreamsorcerer added a commit that referenced this pull request Sep 27, 2026
Dreamsorcerer added a commit that referenced this pull request Sep 27, 2026
)

(cherry picked from commit a921cfd)
(cherry picked from commit 93d91e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant