[PR #13791/7e67714 backport][3.15] Removed old issue template (#13791) by Polandia94 · Pull Request #13800 · aio-libs/aiohttp · GitHub
Skip to content

[PR #13791/7e67714 backport][3.15] Removed old issue template (#13791) - #13800

Merged
webknjaz merged 1 commit into
aio-libs:3.15from
Polandia94:patchback/backports/3.15/7e67714dc2efbe3ed72199841801957873ad8e59/pr-13791
Sep 24, 2026
Merged

webknjaz merged 1 commit into
aio-libs:3.15from
Polandia94:patchback/backports/3.15/7e67714dc2efbe3ed72199841801957873ad8e59/pr-13791

Conversation

@Polandia94

@Polandia94 Polandia94 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Backport cherry-picked from #13791

Remove old issue_template.md file, as the project currently uses issue_template directory

No, this issue template was not accesible when creating an issue

No, this should just remove an unused file

What do these changes do?

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

<!-- Thank you for your contribution! -->
Remove old issue_template.md file, as the project currently uses
issue_template directory

<!-- Please give a short brief about these changes. -->

No, this issue template was not accesible when creating an issue
<!-- Outline any notable behaviour for the end users. -->

No, this should just remove an unused file
<!--
Stop right there! Pause. Just for a minute... Can you think of anything
obvious that would complicate the ongoing development of this project?

Try to consider if you'd be able to maintain it throughout the next
5 years. Does it seem viable? Tell us your thoughts! We'd very much
love to hear what the consequences of merging this patch might be...

This will help us assess if your change is something we'd want to
entertain early in the review process. Thank you in advance!
-->

<!-- Will this resolve any open issues? -->
<!-- Remember to prefix with 'Fixes' if it closes an issue (e.g. 'Fixes

- [ ] I think the code is well written N/A
- [ ] Unit tests for the changes exist N/A
- [ ] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names.
- [ ] Add a new news fragment into the `CHANGES/` folder
  * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`)
  * if you don't have an issue number, change it to the pull request
    number after creating the PR
    * `.bugfix`: A bug fix for something the maintainers deemed an
      improper undesired behavior that got corrected to match
      pre-agreed expectations.
    * `.feature`: A new behavior, public APIs. That sort of stuff.
    * `.deprecation`: A declaration of future API removals and breaking
      changes in behavior.
    * `.breaking`: When something public is removed in a breaking way.
      Could be deprecated in an earlier release.
    * `.doc`: Notable updates to the documentation structure or build
      process.
    * `.packaging`: Notes for downstreams about unobvious side effects
      and tooling. Changes in the test invocation considerations and
      runtime assumptions.
    * `.contrib`: Stuff that affects the contributor experience. e.g.
      Running tests, building the docs, setting up the development
      environment.
    * `.misc`: Changes that are hard to assign to any of the above
      categories.
  * Make sure to use full sentences with correct case and punctuation,
    for example:
    ```rst
    Fixed issue with non-ascii contents in doctest text files
    -- by :user:`contributor-gh-handle`.
    ```
    I think this doesn't require a changes file, ut happy to add it

    Use the past tense or the present tense a non-imperative mood,
    referring to what's changed compared to the last released version
    of this project.

(cherry picked from commit 7e67714)
@Polandia94 Polandia94 added the bot:chronographer:skip This PR does not need to include a change note label Sep 24, 2026
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

@Polandia94 Polandia94 changed the title Removed old issue template (#13791) [PR #13791/7e67714 backport][3.15] Removed old issue template (#13791) Sep 24, 2026
@greptile-apps

greptile-apps Bot commented Sep 24, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

No blocking issue was established; the change is safe to merge.

What we checked:

  • The base commit renders the legacy file, while the PR commit returns a 404 for that file. T-Rex
  • GitHub retirement notices indicate that repositories using the legacy file default to a blank issue form, which influenced the check results. T-Rex
  • Direct chooser verification was blocked by authentication, so a direct filing regression could not be conclusively validated. T-Rex

Reviews (1) · Last reviewed commit: "Removed old issue template (#13791)"

@codspeed

codspeed Bot commented Sep 24, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 8.82%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 9 improved benchmarks
✅ 85 untouched benchmarks
⏩ 86 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_resolve_gitapi_root[pyloop] 5.2 ms 4.7 ms +9.96%
⚡ test_resolve_multiple_level_fixed_url_with_many_routes[pyloop] 21.8 ms 19.9 ms +9.21%
⚡ test_resolve_gitapi_subapps[pyloop] 431.8 ms 396 ms +9.06%
⚡ test_resolve_root_route_with_many_fixed_routes[pyloop] 2.2 ms 2 ms +9.02%
⚡ test_resolve_multiple_fixed_url_with_many_routes[pyloop] 5.5 ms 5.1 ms +8.98%
⚡ test_resolve_single_fixed_url_with_many_routes[pyloop] 2.2 ms 2.1 ms +8.69%
⚡ test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop] 344.1 ms 317.8 ms +8.28%
⚡ test_resolve_root_route[pyloop] 2.2 ms 2 ms +8.12%
⚡ test_resolve_gitapi[pyloop] 415.5 ms 384.5 ms +8.07%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Polandia94:patchback/backports/3.15/7e67714dc2efbe3ed72199841801957873ad8e59/pr-13791 (1ccd298) with 3.15 (916ccff)2

Open in CodSpeed

Footnotes

  1. 86 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on 3.15 (55e4c0f) during the generation of this report, so 916ccff was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@webknjaz
webknjaz merged commit 775d5e1 into aio-libs:3.15 Sep 24, 2026
84 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants