Confidence Score: 5/5

[High risk] Changes how idle connections are closed in the web server.

No outstanding findings block merging.

_{Reviews (6) · Last reviewed commit: "Fix"}

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.03%. Comparing base (e11d283) to head (bbc3b1f).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##           master   #13681   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files         135      135           
  Lines       51418    51506   +88     
  Branches     2695     2696    +1     
=======================================
+ Hits        50923    51011   +88     
  Misses        372      372           
  Partials      123      123           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Merging this PR will not alter performance

✅ 97 untouched benchmarks
⏩ 83 skipped benchmarks¹

_{Comparing fix-idle (bbc3b1f) with master (e11d283)}

Backport to 3.15: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply e07684e on top of patchback/backports/3.15/e07684ef9056183bbefba1ae3f717a23f243631e/pr-13681

Backporting merged PR #13681 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   git remote add upstream https://github.com/aio-libs/aiohttp.git
   

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   git fetch upstream
   git checkout -b patchback/backports/3.15/e07684ef9056183bbefba1ae3f717a23f243631e/pr-13681 upstream/3.15
   

4. Now, cherry-pick PR Close idle connections #13681 contents into that branch:

   git cherry-pick -x e07684ef9056183bbefba1ae3f717a23f243631e
   

   If it'll yell at you with something like fatal: Commit e07684ef9056183bbefba1ae3f717a23f243631e is a merge but no -m option was given., add -m 1 as follows instead:

   git cherry-pick -m1 -x e07684ef9056183bbefba1ae3f717a23f243631e
   

5. At this point, you'll encounter some merge conflicts. You must
   resolve them in order to preserve the patch from PR Close idle connections #13681 as close to the
   original as possible.
6. Once conflicts are resolved and git added, run:

   git cherry-pick --continue
   

7. Push this branch to your fork on GitHub:

   git push origin patchback/backports/3.15/e07684ef9056183bbefba1ae3f717a23f243631e/pr-13681
   

8. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Backport to 3.14: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply e07684e on top of patchback/backports/3.14/e07684ef9056183bbefba1ae3f717a23f243631e/pr-13681

Backporting merged PR #13681 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   git remote add upstream https://github.com/aio-libs/aiohttp.git
   

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   git fetch upstream
   git checkout -b patchback/backports/3.14/e07684ef9056183bbefba1ae3f717a23f243631e/pr-13681 upstream/3.14
   

4. Now, cherry-pick PR Close idle connections #13681 contents into that branch:

   git cherry-pick -x e07684ef9056183bbefba1ae3f717a23f243631e
   

   If it'll yell at you with something like fatal: Commit e07684ef9056183bbefba1ae3f717a23f243631e is a merge but no -m option was given., add -m 1 as follows instead:

   git cherry-pick -m1 -x e07684ef9056183bbefba1ae3f717a23f243631e
   

5. At this point, you'll encounter some merge conflicts. You must
   resolve them in order to preserve the patch from PR Close idle connections #13681 as close to the
   original as possible.
6. Once conflicts are resolved and git added, run:

   git cherry-pick --continue
   

7. Push this branch to your fork on GitHub:

   git push origin patchback/backports/3.14/e07684ef9056183bbefba1ae3f717a23f243631e/pr-13681
   

8. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.