Fix cookie overflow by Dreamsorcerer · Pull Request #13677 · aio-libs/aiohttp · GitHub
Skip to content

Fix cookie overflow - #13677

Merged
Dreamsorcerer merged 5 commits into
masterfrom
fix-cookie-overflow
Sep 9, 2026
Merged

Fix cookie overflow#13677
Dreamsorcerer merged 5 commits into
masterfrom
fix-cookie-overflow

Conversation

@Dreamsorcerer

@Dreamsorcerer Dreamsorcerer commented Sep 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot labels Sep 9, 2026
@pyba-chronographer pyba-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Sep 9, 2026
@codecov

codecov Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Dreamsorcerer
Dreamsorcerer commented Sep 9, 2026
View reviewed changes
Comment thread tests/test_cookiejar.py Outdated
Dreamsorcerer
Dreamsorcerer commented Sep 9, 2026
View reviewed changes
Comment thread tests/test_client_functional.py Outdated
@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

Safe to merge based on focused runtime coverage of both corrected failure paths.

The executed before-and-after checks exercised oversized positive and negative cookie expiration values and a cookie-processing exception after response receipt. The updated behavior matched the intended handling, and all focused regression tests passed.

Files Needing Attention: No further files need attention; the exercised changes are in aiohttp/cookiejar.py, aiohttp/client.py, and their focused regression tests.

T-Rex T-Rex Logs

What T-Rex did

  • Ran the CookieJar and in-process client harnesses against the previous and updated implementations, then ran the focused cookiejar and client-functional pytest selections.
  • Observed that the previous implementation raised OverflowError when handling a 309-digit positive Max-Age and retained one acquired connection after the cookie-jar exception.
  • Applied the changes to clamp positive Max-Age to CookieJar.MAX_TIME, immediately expire negative Max-Age, report zero acquired connections after the exception, and allow the follow-up request to complete.
  • Executed the focused regression selections and confirmed all six tests passed, validating the corrected cookie expiration and response cleanup behavior.
  • Cross-validated the changes against the targeted code areas and reviewed the accompanying artifacts to verify the before-and-after overflow handling and cleanup behavior.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Apply suggestion from @Dreamsorcerer" | Re-trigger Greptile

@codspeed

codspeed Bot commented Sep 9, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 97 untouched benchmarks
⏩ 83 skipped benchmarks1

Comparing fix-cookie-overflow (2f49592) with master (9332972)

Open in CodSpeed

Footnotes

  1. 83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dreamsorcerer
Dreamsorcerer merged commit 9e08ba0 into master Sep 9, 2026
53 checks passed
@Dreamsorcerer
Dreamsorcerer deleted the fix-cookie-overflow branch September 9, 2026 02:08
@patchback

patchback Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport to 3.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.15/9e08ba02abe573ce9e4cc541d4e3c3646adb43a7/pr-13677

Backported as #13678

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback Bot mentioned this pull request Sep 9, 2026
Merged
@patchback

patchback Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@patchback patchback Bot mentioned this pull request Sep 9, 2026
Merged
Dreamsorcerer added a commit that referenced this pull request Sep 9, 2026
@patchback @Dreamsorcerer
[PR #13677/9e08ba02 backport][3.15] Fix cookie overflow (#13678)
3141d5a 
**This is a backport of PR #13677 as merged into master
(9e08ba0).**

---------

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Sep 9, 2026
@patchback @Dreamsorcerer
[PR #13677/9e08ba02 backport][3.14] Fix cookie overflow (#13679)
9dd8eaf 
**This is a backport of PR #13677 as merged into master
(9e08ba0).**

---------

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dreamsorcerer