Repository navigation
Stop the benchmark CI job hanging on apt - #13489
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Confidence Score: 5/5The PR appears safe to merge with no actionable blocking or non-blocking issues identified. The workflow now bounds each apt operation, retries failed installations, and retains a job-level timeout while preserving the benchmark execution path after successful installation. Reviews (1): Last reviewed commit: "Reword change note for the spell checker" | Re-trigger Greptile |
Backport to 3.15: 💚 backport PR created✅ Backport PR branch: Backported as #13490 🤖 @patchback |
… on apt (#13490) Co-authored-by: J. Nick Koston <nick@koston.org>
… on apt (#13491) Co-authored-by: J. Nick Koston <nick@koston.org>

What do these changes do?
The
Benchmarkjob has been getting cancelled at its 15 minute limit, so CodSpeed stopped reporting on some PRs (for example https://github.com/aio-libs/aiohttp/actions/runs/32157680880/job/95779217306). The job logs show it stuck right after the CodSpeed runner printsInstalling packages: /tmp/valgrind-codspeed.deb, libc6-dbg; that is a plainapt-get updateplusapt-get install libc6-dbginside the runner with no timeout, and it has taken anywhere from 37 seconds to over 14 minutes on the same runner image today. It runs even after the runner restores valgrind from its cache, because the runner also checksdpkg -s libc6-dbgand the cache only copies files.This adds a step that installs
libc6-dbgbefore the CodSpeed action with atimeoutand a retry loop, so a stalled mirror fails fast and retries instead of hanging; once it is registered in dpkg the runner finds it present after its cache restore and skips apt entirely. It also raises the job timeout to 30 minutes, since a slow install plus the ~9 minute benchmark suite already blew past 15 in one run.Are there changes in behavior for the user?
No, CI only.
Is it a substantial burden for the maintainers to support this?
No; one extra workflow step and a timeout bump.
Related issue number
None.
Checklist
CONTRIBUTORS.txtN/ACHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.