{{ message }}
Repository navigation
[PR #13249/3c6cf44d backport][3.14] Fix segfault when decompression fails while draining pending data - #13272
Merged
Dreamsorcerer merged 1 commit intoJul 27, 2026
Conversation
3 of 5 tasks
Dreamsorcerer
deleted the
patchback/backports/3.14/3c6cf44da3e5c984655c58784818ce5bf3f4d05c/pr-13249
branch
July 27, 2026 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is a backport of PR #13249 as merged into master (3c6cf44).
What do these changes do?
The llhttp callbacks in the C parser are declared
except -1, which promises Cython that a -1 return always has an exception pending. The callbacks actually return -1 as a plain abort status after catching the error and stashing it for later delivery. That is fine when llhttp calls them, butfeed_dataalso callscb_on_bodydirectly to drain pending decompressed data; when the decompressor raises during that drain, Cython takes the error path with no exception set and crashes in__Pyx_AddTracebackon Python 3.12 and newer. This happens in the wild with brotlicffi 1.2, see python-hyper/brotlicffi#225 and cython/cython#7857.The callbacks are now declared
except? -1so Cython checksPyErr_Occurred()before taking the error path, and the drain call handles the failure explicitly; the error reaches the user through the payload asContentEncodingErrorlike other payload errors.Are there changes in behavior for the user?
A decompression failure while draining pending data now raises
ContentEncodingErrorinstead of crashing the interpreter.Is it a substantial burden for the maintainers to support this?
No, the exception declarations now match what the callbacks actually do.
Related issue number
Fixes #13203.
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.
Test output
The new test reproduces the crash on the unfixed extension:
With the fix, on Python 3.14.2 with the C extension built:
Pure Python mode:
The regenerated call site in
_http_parser.cnow guards the error path:Drafted with Claude Code (Fable 5); reviewed by bdraco.