{{ message }}
This repository was archived by the owner on Oct 14, 2026. It is now read-only.
Repository navigation
feat(data-access): geo-experiment auto-extend phases, post_extension insights types and extension config - #1972
Open
ssilare-adobe wants to merge 2 commits into
Open
ssilare-adobe wants to merge 2 commits into
ssilare-adobe wants to merge 2 commits into
Conversation
…nd taken-based runRange
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Data-model support for geo-experiment auto-extend (post window keeps running for up to 4 windows of 14 runs, same post DRS schedule).
INSIGHTS_TYPES:baseline,post_analysis,post_extension_{n}(window N ≥ 2 →post_extension_{N-1});insightsTypeForWindowupdated.runRangeoninsightsListentries is now{ min, max, taken: [ascending run numbers] }—takenis the post run numbers Mystique's selection actually used (gaps from missing / dropped runs allowed);min/maxmust equal first/last taken.POST_EXTENSION_STARTED,POST_EXTENSION_ANALYSIS_STARTED,POST_EXTENSION_ANALYSIS_DONE,POST_EXTENSION_IMPACT_MEASUREMENT_STARTED,POST_EXTENSION_IMPACT_MEASUREMENT_DONE.EXTENSION_CONFIG_ENV_VAR = 'EXPERIMENT_EXTENSION_CONFIG',METADATA_KEYS.EXTENSION,EXTENSION_CONFIG_KEYS,EXTENSION_MAX_WINDOWS = 4,EXTENSION_DEFAULT_WINDOW_SIZE = 14.GeoExperimentRunRange,GeoExperimentExtension) and unit tests updated.Breaking for writers of the previous
extensiontype /{from,to}runRange — none in this package; consumers (api-service, engine) are updated in companion PRs.Design: https://wiki.corp.adobe.com/pages/viewpage.action?pageId=4058181823
Test plan
npm test -w packages/spacecat-shared-data-access(3068 passing, geo-experiment.model.js 100%)