{{ message }}
Repository navigation
Conversation
A prepare sheet row with sdk = 2 gets no IMS token. The menu connects its iframe to the da-nx extension host, which proxies daFetch for the extension. Rows without the column keep the current token handshake. Refs adobe#1408
This was referenced Oct 15, 2026
# Conflicts: # blocks/canvas/editor-utils/prepare-menu.js
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Today, the prepare menu sends the user's IMS token to every extension iframe. This change lets a prepare sheet row opt in to SDK2. An SDK2 extension gets no token. It gets a
daFetchthat the host runs for it. Refs #1408.What changed
sdkcolumn in thepreparesheet. An empty cell or1keeps the current behavior.2connects the iframe to the da-nx extension host (connectExtension). The menu hides a row with any other value, so a typo never sends the token.Scope
nx2/utils/extension-host.jsand the SDK.sdk = 2.Blast Radius
Rows without the
sdkcolumn work as before, and the existing tests for them still pass. The SDK2 path runs only for rows withsdk = 2.Verification
npm test: 2501 passed, 0 failed. New tests cover thesdkcolumn parser, SDK2 connect and close, hidden invalid rows, and the reused-iframe race.?nx=localand a test extension inbpauli/frescopa. "Add to snapshot" added the page to a snapshot (HTTP 200) through the host. The extension frame got no token, and requests to another site were denied.