Disable 9.0.0 displayio warnings by dhalbert · Pull Request #9096 · adafruit/circuitpython · GitHub
Skip to content

Disable 9.0.0 displayio warnings#9096

Merged
dhalbert merged 1 commit into
adafruit:9.0.xfrom
dhalbert:9.0.x-disable-displayio-warnings
Mar 26, 2024
Merged

Disable 9.0.0 displayio warnings#9096
dhalbert merged 1 commit into
adafruit:9.0.xfrom
dhalbert:9.0.x-disable-displayio-warnings

Conversation

@dhalbert

Copy link
Copy Markdown
Collaborator

Turn off displayio warnings when using 8.x naming. This was intrusive and confusing for some users. Turn this back on when 8.x bundles are no longer being built.

@dhalbert dhalbert requested a review from tannewt March 26, 2024 20:08

@tannewt tannewt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt

tannewt commented Mar 26, 2024

Copy link
Copy Markdown
Member

@dhalbert

dhalbert commented Mar 26, 2024

Copy link
Copy Markdown
Collaborator Author

I wonder if this should be 8_10 warnings? 9 has both.

I meant it was warnings reflecting changes between 8 and 9. This code would be removed entirely in 10. But the name doesn't matter a lot.

@dhalbert

Copy link
Copy Markdown
Collaborator Author

@dhalbert dhalbert merged commit 6d1b940 into adafruit:9.0.x Mar 26, 2024
@dhalbert dhalbert deleted the 9.0.x-disable-displayio-warnings branch March 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants