{{ message }}
M5stack Stick-C fixes#7818
Merged
Merged
Conversation
CDarius
commented
Mar 30, 2023
CDarius
commented
- Fixed the boot led definition in mpconfigboard.h. The led is inverted (low active)
- Set IR led gpio low during espressif_board_reset_pin_number to avoid power drain from the led
- Defined the gpio pin connect to AXP192 N_VBUSSEN input
- Update AXP192 pmu initialization:
- Increased low battery warning 1 to 3.695V
- Increased low battery warning 2 to 3.600V
- Disable interrupt except:
- Low battery warning
- Power button short press
- Power button long press
dhalbert
approved these changes
Mar 30, 2023
dhalbert
left a comment
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
Thanks - I'll take your word for the fixes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.