{{ message }}
Consistently validate location on VectorShape#5327
Merged
Conversation
VectorShape object so that it is consistent no matter where it is set from: * the constructor * the x and y setters * the location setter
kvc0
suggested changes
Sep 10, 2021
kvc0
left a comment
kvc0
left a comment
There was a problem hiding this comment.
Validation consistency changes look good! I am concerned about breaking the correct semantic of the module set_location family functions.
…ng most of the code into shared-module.
Author
kvc0
reviewed
Sep 11, 2021
microdev1
approved these changes
Sep 11, 2021
microdev1
left a comment
microdev1
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks for the PR @lesamouraipourpre and @WarriorOfWire for the review.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5325
The x, y or location properties now use the same bounds validation whether set via the constructor or setters.
Tested with the code in #5325 which now raises Errors consistently when out of range.
@WarriorOfWire can you check if these changes are consistent with the rewrite and pass any test code you have?