Espruino Pico: Remove settings for DNP oscillator by hierophect · Pull Request #4719 · adafruit/circuitpython · GitHub
Skip to content

Espruino Pico: Remove settings for DNP oscillator#4719

Merged
dhalbert merged 2 commits into
adafruit:mainfrom
hierophect:stm-espr-pico-fix
May 7, 2021
Merged

Espruino Pico: Remove settings for DNP oscillator#4719
dhalbert merged 2 commits into
adafruit:mainfrom
hierophect:stm-espr-pico-fix

Conversation

@hierophect

Copy link
Copy Markdown
Collaborator

The LSE on the Espruino Pico is actually DNP, which isn't documented on the schematic. This was causing a clock failure after the 6.0 STM32 timekeeping reworks.

Resolves #4714

@hierophect hierophect added the stm label May 6, 2021
@hierophect hierophect requested a review from dhalbert May 6, 2021 17:56
@hierophect

Copy link
Copy Markdown
Collaborator Author

@dhalbert

dhalbert commented May 6, 2021

Copy link
Copy Markdown
Collaborator

It appears the CI is failing for unrelated reasons on the ESP32-S2, nothing to do with this I don't think.

Yeah, I fixed the build problem with #4721. This seems to happen every time there is some updated software on the build system VPS's.

@dhalbert

dhalbert commented May 6, 2021

Copy link
Copy Markdown
Collaborator

@hierophect Could you drop an Espruino Pico build in #4714 for the OP there to test? I thought I could point to an artifact, but I don't see any artifacts. Thanks.

@hierophect

Copy link
Copy Markdown
Collaborator Author

That's weird, don't they normally show up even when the build fails overall? Anyway yeah I can drop one over there.

@dhalbert

dhalbert commented May 6, 2021

Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out! And thanks to @valholl for testing!

@dhalbert dhalbert merged commit 2fe1df4 into adafruit:main May 7, 2021
@hierophect hierophect deleted the stm-espr-pico-fix branch May 7, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CircuitPython 6.2.0 does not boot on Espruino Pico

2 participants