update ulab by jepler · Pull Request #2711 · adafruit/circuitpython · GitHub
Skip to content

update ulab#2711

Merged
tannewt merged 7 commits into
adafruit:masterfrom
jepler:update-ulab
Mar 17, 2020
Merged

update ulab#2711
tannewt merged 7 commits into
adafruit:masterfrom
jepler:update-ulab

Conversation

@jepler

@jepler jepler commented Mar 16, 2020

Copy link
Copy Markdown

This pulls in all of @v923z's updates to ulab so that we can check that they build. It also needs:

  • testing
  • doc updates in the CPy copy of the documentation

before it can be merged.

@jepler jepler requested a review from tannewt March 17, 2020 15:28

@tannewt tannewt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are so many translation entries deleted? One typo in docs.

Comment thread shared-bindings/ulab/__init__.rst Outdated
Co-Authored-By: Scott Shawcroft <scott@tannewt.org>
@jepler

jepler commented Mar 17, 2020

Copy link
Copy Markdown
Author

@jepler

jepler commented Mar 17, 2020

Copy link
Copy Markdown
Author

@tannewt tannewt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Totally ok to have the translation fix here. Thanks!

@tannewt tannewt merged commit 4603c6d into adafruit:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants