Merge in gamepadshift fix to master. by tannewt · Pull Request #1943 · adafruit/circuitpython · GitHub
Skip to content

Merge in gamepadshift fix to master.#1943

Merged
tannewt merged 2 commits into
masterfrom
4.0.x
Jun 13, 2019
Merged

Merge in gamepadshift fix to master.#1943
tannewt merged 2 commits into
masterfrom
4.0.x

Conversation

@tannewt

@tannewt tannewt commented Jun 13, 2019

Copy link
Copy Markdown
Member

No description provided.

deshipu and others added 2 commits June 12, 2019 11:42
When reading the accumulated button presses in gamepad and gamepadshift,
don't clear the buffer to "no buttons pressed", but instead set it to
the current (last checked) state. This clears the accumulated presses,
but retains any ongoing ones.

This fixes #1935
When clearing gamepad buffer, use the last button state, not 0
@tannewt tannewt requested a review from dhalbert June 13, 2019 18:37

@dhalbert dhalbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping master up to date.

@tannewt tannewt merged commit 6d388a3 into master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants