UART enhancements by dhalbert · Pull Request #1186 · adafruit/circuitpython · GitHub
Skip to content

UART enhancements#1186

Merged
tannewt merged 3 commits into
adafruit:3.xfrom
dhalbert:uart-enhancements
Sep 12, 2018
Merged

UART enhancements#1186
tannewt merged 3 commits into
adafruit:3.xfrom
dhalbert:uart-enhancements

Conversation

@dhalbert

Copy link
Copy Markdown
Collaborator
  • Cherry-pick 02b3f62 UART timeout zero fix from master to 3.x.
  • Add UART.in_waiting -- characters in buffer waiting to be read (duplicating PySerial API)
  • Add UART.reset_input_buffer() -- clear input buffer, discarding unread characters (PySerial API)
  • Remove unused fields in UART object.
  • Clear board.{UART,SPI,I2C} singletons on soft reset. Previously a ctrl-D wouldn't clear these objects, and trying to create them again and use them would cause a crash.
  • Clean up #if logic in board_busses.c.

Had to lower -finline-limit again slightly to make small builds git.

@dhalbert dhalbert requested review from ladyada and tannewt September 12, 2018 21:26
@dhalbert dhalbert changed the title Uart enhancements UART enhancements Sep 12, 2018
@ladyada

ladyada commented Sep 12, 2018

Copy link
Copy Markdown
Member

ladyada
ladyada previously approved these changes Sep 12, 2018
tannewt
tannewt previously approved these changes Sep 12, 2018

@tannewt tannewt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Awesome fixes!

@dhalbert dhalbert dismissed stale reviews from tannewt and ladyada via c7c2486 September 12, 2018 22:14
@tannewt tannewt merged commit 2dd9407 into adafruit:3.x Sep 12, 2018
@ladyada ladyada mentioned this pull request Sep 13, 2018
5 tasks
@dhalbert

Copy link
Copy Markdown
Collaborator Author

@dhalbert dhalbert deleted the uart-enhancements branch September 13, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants