{{ message }}
must set pull after setting direction with gpio_set_pin routines#1006
Merged
Conversation
kattni
approved these changes
Jul 9, 2018
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Thanks for the fix! Tested successfully on ItsyBitsy M0 and M4 with test builds. Will merge once Travis is happy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpio_set_pin_pull_mode()must come aftergpio_set_pin_direction(). I reversed this in one case because I thought it might avoid a glitch on the pin, but it didn't work.This is an example of why we need HW regression tests.