iframe-proxy

johnshajiang · 2024-08-14T03:48:20Z

Description:
This PR adds Tencent Kona JDK into setup-java.
It supports the major versions 8, 11, 17 and 21.
The supported platforms are Linux x86_64/aarch64, macOS x86_64/aarch64 and Windows x86_64.

Currently, only the latest stable releases are supported, and only jdk (no jre) binaries are available.
A configuration maintains these releases.

Related issue:
#671

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

johnshajiang · 2024-09-12T07:17:15Z

johnshajiang · 2024-10-10T09:23:35Z

I just updated the commit again, and the file conflicts are resolved.

Signed-off-by: John Jiang <johnsjiang@tencent.com>

johnshajiang · 2025-02-13T15:11:37Z

I already executed npm run build for re-generating the index.js files, and committed them.

> setup-java@4.0.0 build
> ncc build -o dist/setup src/setup-java.ts && ncc build -o dist/cleanup src/cleanup-java.ts

ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
ncc: Using typescript@5.3.3 (local user-provided)
5204kB  dist/setup/index.js
5204kB  [2160ms] - ncc 0.38.1
ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
ncc: Using typescript@5.3.3 (local user-provided)
3777kB  dist/cleanup/index.js
3777kB  [1804ms] - ncc 0.38.1

But Check dist check task always failed.

Signed-off-by: John Jiang <johnsjiang@tencent.com>

brunoborges · 2026-06-23T01:16:43Z

Linking the tracking issue: this PR implements #671 (Tencent Kona JDK support). Maintainers — adding Closes #671 to the PR description will auto-close the issue on merge.

Signed-off-by: John Jiang <johnsjiang@tencent.com>

Copilot

Pull request overview

This PR adds support for the Tencent Kona JDK distribution to actions/setup-java, including the installer implementation, documentation, and test/e2e coverage.

Changes:

Add a new KonaDistribution that resolves Kona JDK downloads from the published kona-v1.json configuration.
Register the new kona distribution in the distribution factory and bundled dist output.
Update docs, e2e matrix, and add unit tests + fixture manifest data for Kona.

Show a summary per file

File	Description
`src/distributions/kona/models.ts`	Adds Kona release/config TypeScript models.
`src/distributions/kona/installer.ts`	Implements Kona distribution resolution and download/extract logic.
`src/distributions/distribution-factory.ts`	Registers `kona` as a supported distribution and wires installer creation.
`README.md`	Documents `kona` as a supported distribution and links to advanced usage.
`docs/advanced-usage.md`	Adds a “Tencent Kona” usage section and TOC entry.
`__tests__/distributors/kona-installer.test.ts`	Adds unit tests for Kona release selection and error cases.
`__tests__/data/kona.json`	Adds fixture manifest data used by the Kona unit tests.
`.github/workflows/e2e-versions.yml`	Adds `kona` to the e2e distribution matrix.
`dist/setup/index.js`	Updates the bundled action output to include the new Kona installer.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 8/9 changed files
Comments generated: 5

+    const availableReleases = await this.getAvailableReleases();
+    const releases = availableReleases
+      .filter(item => {
+        return isVersionSatisfies(version, item.version);
+      })
+      .map(item => {
+        return {
+          version: item.version,
+          url: item.downloadUrl
+        } as JavaDownloadRelease;
+      });
+
+    if (!releases.length) {
+      throw new Error(
+        `No Kona release for the specified version "${version}" on OS "${this.getOs()}" and arch "${this.getArch()}".`
+      );
+    }
+
+    return releases[0];
+  }


+import fs from 'fs';
+import path from 'path';
+


+import {
+  extractJdkFile,
+  getDownloadArchiveExtension,
+  isVersionSatisfies
+} from '../../util';


+    const javaArchivePath = await tc.downloadTool(javaRelease.url);
+
+    core.info(`Extracting Java archive...`);
+
+    const extension = getDownloadArchiveExtension();
+    const extractedJavaPath = await extractJdkFile(javaArchivePath, extension);


+    if (core.isDebug()) {
+      console.time('Retrieving available releases for Kona took'); // eslint-disable-line no-console
+    }
+
+    const releaseInfo = await this.fetchReleaseInfo();
+    if (!releaseInfo) {
+      throw new Error(`Couldn't fetch Kona release information`);
+    }
+
+    const availableReleases = this.chooseReleases(
+      this.getOs(),
+      this.getArch(),
+      releaseInfo
+    );
+
+    if (core.isDebug()) {
+      core.startGroup('Print information about available releases');
+      core.debug(availableReleases.map(item => item.version).join(', '));
+      core.endGroup();
+    }


Signed-off-by: John Jiang <johnsjiang@tencent.com>

johnshajiang · 2026-06-24T07:02:16Z

johnshajiang requested a review from a team as a code owner August 14, 2024 03:48

johnshajiang mentioned this pull request Aug 14, 2024

Support Tencent Kona JDK #671

Open

johnshajiang force-pushed the support-kona-jdk branch from 9871695 to a8506e9 Compare September 12, 2024 07:13

johnshajiang force-pushed the support-kona-jdk branch from a8506e9 to 8549eb9 Compare October 10, 2024 09:16

johnshajiang force-pushed the support-kona-jdk branch 3 times, most recently from 41ce0ca to 109744b Compare February 13, 2025 08:31

johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025

Support Tencent Kona JDK (actions#672)

08f4b36

Signed-off-by: John Jiang <johnsjiang@tencent.com>

johnshajiang force-pushed the support-kona-jdk branch from 109744b to 08f4b36 Compare February 13, 2025 09:03

johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025

Support Tencent Kona JDK (actions#672)

38b6474

Signed-off-by: John Jiang <johnsjiang@tencent.com>

johnshajiang force-pushed the support-kona-jdk branch from 08f4b36 to 38b6474 Compare February 13, 2025 09:16

johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025

Support Tencent Kona JDK (actions#672)

8b5e418

Signed-off-by: John Jiang <johnsjiang@tencent.com>

johnshajiang force-pushed the support-kona-jdk branch from 38b6474 to 8b5e418 Compare February 13, 2025 09:59

johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025

Support Tencent Kona JDK (actions#672)

e003e7e

Signed-off-by: John Jiang <johnsjiang@tencent.com>

johnshajiang force-pushed the support-kona-jdk branch from 8b5e418 to e003e7e Compare February 13, 2025 14:57

johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025

Support Tencent Kona JDK (actions#672)

6dd1e44

Signed-off-by: John Jiang <johnsjiang@tencent.com>

johnshajiang force-pushed the support-kona-jdk branch from e003e7e to 6dd1e44 Compare February 13, 2025 15:05

johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 14, 2025

Support Tencent Kona JDK (actions#672)

7364a19

Signed-off-by: John Jiang <johnsjiang@tencent.com>

brunoborges added feature request New feature or request to improve the current logic distribution JDK distribution/version/source support and removed feature request New feature or request to improve the current logic labels Jun 22, 2026

brunoborges added the stale The issue has been open for a year without any activity label Jun 23, 2026

brunoborges changed the title ~~Support Tencent Kona JDK~~ dist: Support Tencent Kona JDK Jun 23, 2026

brunoborges pushed a commit to johnshajiang/actions-setup-java that referenced this pull request Jun 23, 2026

Support Tencent Kona JDK (actions#672)

59e214a

Signed-off-by: John Jiang <johnsjiang@tencent.com>

brunoborges force-pushed the support-kona-jdk branch from 6dd1e44 to 59e214a Compare June 23, 2026 19:28

brunoborges requested a review from Copilot June 23, 2026 19:33

Copilot started reviewing on behalf of brunoborges June 23, 2026 19:33 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

Support Tencent Kona JDK (actions#672)

39f01ea

Signed-off-by: John Jiang <johnsjiang@tencent.com>

brunoborges force-pushed the support-kona-jdk branch from 59e214a to 39f01ea Compare June 23, 2026 20:01

brunoborges approved these changes Jun 24, 2026

View reviewed changes

brunoborges mentioned this pull request Jun 25, 2026

chore: enforce pre-PR validation (aggregate scripts, git hooks, PR checklist) #1061

Open

3 tasks

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

dist: Support Tencent Kona JDK#672

dist: Support Tencent Kona JDK#672
johnshajiang wants to merge 1 commit into
actions:mainfrom
johnshajiang:support-kona-jdk

johnshajiang commented Aug 14, 2024 •

edited

Loading

Uh oh!

johnshajiang commented Sep 12, 2024

Uh oh!

johnshajiang commented Oct 10, 2024

Uh oh!

johnshajiang commented Feb 13, 2025 •

edited

Loading

Uh oh!

brunoborges commented Jun 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

johnshajiang commented Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

johnshajiang commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnshajiang commented Sep 12, 2024

Uh oh!

johnshajiang commented Oct 10, 2024

Uh oh!

johnshajiang commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunoborges commented Jun 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

johnshajiang commented Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johnshajiang commented Aug 14, 2024 •

edited

Loading

johnshajiang commented Feb 13, 2025 •

edited

Loading