{{ message }}
Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Fix Dependency Review reporting GitHub Actions dependencies as having an unknown license when the Dependency Graph response does not include a license or source repository URL.
This was encountered while investigating ossf/scorecard#5090, where Dependency Review reported dependencies such as
actions/cacheas having an unknown license even though the repository has a valid license.Why
For some GitHub Actions dependencies, the Dependency Graph API can return both
license: nullandsource_repository_url: null.In these cases, the package URL still contains the GitHub repository information. For example:
pkg:githubactions/actions/cache@6.%2A.%2AThe existing license fallback relies on
source_repository_url, so the logic classifies these dependencies as unlicensed without attempting to fetch their repository license.How
Add a fallback for
githubactionspackage URLs whensource_repository_urlis unavailable.Derive the GitHub repository owner and name from the PURL, then use the existing GitHub license API lookup to fetch the repository license.
The existing
source_repository_urlbehavior remains unchanged.Test
Add a regression test for an
actions/cachedependency with:The test verifies that the fallback calls the GitHub license API with:
The test also verifies that the fallback no longer classifies the dependency as unlicensed.
All existing tests pass: