{{ message }}
Repository navigation
Convert GarminResponse, GarminJson, GarminGcmJsonActivities to LAVA @artifact_processor - #775
Merged
Merged
Conversation
…artifact_processor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three Garmin JSON-cache 'viewer' artifacts. Originally each rendered a 'View' button + an embedded HTML JSON panel (
add_json_to_artifact) — both HTML-report-only. For LAVA the actual JSON string is the data, so the button column now holds the pretty-printed JSON itself.response_cache;lastUpdateraw → aware UTCdatetime;Responsecolumn = the cached JSON (pretty-printed) instead of a button.jsontable;saved_timestampraw → aware UTCdatetime;jsoncolumn = the cached value (pretty-printed).json_activitiestable;saved_timestampraw → aware UTCdatetime;jsoncolumn = the cached value (pretty-printed); empty[]rows yield ''.Added a shared
_pretty_jsonhelper with a guarded parse (malformed JSON returns the raw string instead of crashing, which the original did not handle). Droppedadd_json_to_artifact/filter_by_date/the buttons; the JSON cells are no longerhtml_escape=False, so content is safely escaped in the HTML report.Verified: byte-compile, decorated 4-arg signatures, return 3-tuples, output_types valid, _pretty_json guard tested, loader builds (407 plugins), pylint clean.