{{ message }}
Repository navigation
Fix LAVA duplicate-name collisions (unique artifact names) - #771
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LAVA keys artifacts by display name and only shows the first when names collide; category only controls grouping. This makes the affected names unique while keeping categories intact for grouping.
chrome.py (the reported case): the multi-browser pattern emits a combined table (named by the artifact's
name) plus per-browser tables ({browser} - <type>). With the combined artifacts namedChrome - Web Historyetc., they collided exactly with the Chrome browser's own per-browser table (e.g. twoChrome - Web Historyentries — 76 combined vs 34 Chrome-only). Renamed the 5 combined artifacts to report-type-only —Web History,Web Visits,Search Terms,Downloads,Keyword Search Terms— matching the existingBookmarks/Offline Pagessiblings. Combined names no longer equal any{browser} - <type>table.Burner (4 artifacts all named "Burner: Second Phone Number"): →
Burner - Contacts / Messages / Subscription / User(category staysBurner).Bluesky (3 named "Bluesky"): →
Bluesky - Messages / Posts / Searches(category staysBluesky).ChatGPT (2 named "ChatGPT"): kept the comprehensive
chatgpt.pyasChatGPT; renamed the secondarychatgpt2.py→ChatGPT - Conversations(category staysChatGPT).Verified: byte-compile, a repo-wide scan shows no remaining cross-file duplicate names and no
Chrome -combined names, and the plugin loader builds (407 plugins).