{{ message }}
Repository navigation
Convert imo and samsungWeatherClock to LAVA (multi-report split) - #736
Merged
Merged
Conversation
Split two multi-report artifacts into one @artifact_processor function per table: - imo: get_imo_account (accountdb.db) and get_imo_messages (imofriends.db, with JSON attachment parsing). Each entry now targets its specific database path. - samsungWeatherClock: get_samsungWeatherClockInfo / Daily / Hourly, all reading the WeatherClock db via a shared _weatherclock_db helper; datetime columns marked. Queries and rows unchanged (structurally verified against main). Function keys dropped since decorated functions resolve by name.
Convert datetime columns to tz-aware UTC so LAVA stores correct unix epochs (naive UTC strings were being read as local time). imo also drops the deprecated datetime.utcfromtimestamp in favor of datetime.fromtimestamp(ts, timezone.utc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits two multi-report artifacts into one
@artifact_processorfunction per table.get_imo_account(accountdb.db) andget_imo_messages(imofriends.db, JSON attachment parsing preserved). Each entry targets its specific database path.get_samsungWeatherClockInfo/Daily/Hourly, all reading the WeatherClock db via a shared_weatherclock_dbhelper; datetime columns marked.Queries and row extraction unchanged (verified structurally against
main). Function keys dropped; decorated functions resolve by name.Verified: both parse, lint-clean, plugin loader resolves all five functions with no warnings, and queries/rows match
main.