Conversation
- Fetch all versions for a given PURL Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
JonoYang
left a comment
There was a problem hiding this comment.
@keshav-space I've left some suggestions to avoid accessing a dictionary multiple times for the same key-value pair.
https://crates.io/policies#crawlers Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
4fbba5e to
6faf263
Compare
|
LGTM... we need to find a better name for this module, may be "package_versions.py" for now? Beyond this we need to have a better design. Here are some thoughts (to track in new issue(s)):
We also need to make the migration for VulnerableCode with this new code. Can you start a PR in parallel so we avoid duplicating code. In VCIO you could use a temp requirements in setup.cfg such as |
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
a314803 to
128d8bc
Compare
JonoYang
left a comment
There was a problem hiding this comment.
@keshav-space I left some comments regarding adding comments or docstring tests.
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
JonoYang
left a comment
There was a problem hiding this comment.
@keshav-space I think this looks good!

This PR migrates existing package managers code in VulnerableCode to FetchCode, also refactor and streamline the consumption using purl router.