Fix: add missing exit_stack.close() to end of /v1/completions endpoint by gjpower · Pull Request #1795 · abetlen/llama-cpp-python · GitHub
Skip to content

Fix: add missing exit_stack.close() to end of /v1/completions endpoint#1795

Closed
gjpower wants to merge 1 commit into
abetlen:mainfrom
gjpower:fix/missing_exit_stack_call
Closed

Fix: add missing exit_stack.close() to end of /v1/completions endpoint#1795
gjpower wants to merge 1 commit into
abetlen:mainfrom
gjpower:fix/missing_exit_stack_call

Conversation

@gjpower

@gjpower gjpower commented Oct 14, 2024

Copy link
Copy Markdown
Contributor
  • /v1/completions endpoint was missing an exit_stack.close() call

This was causing the llama proxy lock to be retained until exit_stack is cleaned up by garbage collector

@gjpower

gjpower commented Oct 15, 2024

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant