iframe-proxy

guglielmo-san · 2026-03-19T17:34:06Z

Description

This PR refactors the jsonrpc server implementation to expose Starlette Route components directly (via AgentCardRoutes, JsonRpcRoutes) instead of requiring full FastAPI or Starlette application wrappers.

Ref #797 🦕

gemini-code-assist · 2026-03-19T17:34:40Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the server-side implementation for handling JSON-RPC and agent card endpoints. Instead of providing framework-specific application classes, the system now offers granular routing components (JsonRpcRoutes and AgentCardRoutes). This change enhances the modularity and flexibility of the server, allowing developers to integrate these functionalities more seamlessly into existing Starlette or FastAPI applications by composing routes, rather than relying on pre-built application wrappers.

Highlights

Modularization of JSON-RPC and Agent Card Endpoints: The previous monolithic A2AFastAPIApplication and A2AStarletteApplication classes have been removed. Their functionalities are now split into dedicated JsonRpcRoutes and AgentCardRoutes classes, promoting better separation of concerns and reusability.
Refactoring of JSONRPCApplication to JsonRpcDispatcher: The core logic for handling JSON-RPC requests, previously encapsulated in JSONRPCApplication, has been refactored into a new class named JsonRpcDispatcher. This dispatcher focuses solely on processing JSON-RPC messages, decoupling it from the web framework routing specifics.
Simplified Application Setup: Sample and test files have been updated to reflect the new modular structure, demonstrating how to integrate JsonRpcRoutes and AgentCardRoutes directly with Starlette and FastAPI applications by extending their route lists.
Removal of Redundant Application Classes: The fastapi_app.py and starlette_app.py modules within a2a.server.apps.jsonrpc have been removed, along with their corresponding imports and __all__ entries, as their functionality is now handled by the new routing system.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-03-19T17:37:04Z

🧪 Code Coverage (vs `1.0-dev`)

⬇️ Download Full Report

	Base	PR	Delta
src/a2a/server/routes/agent_card_routes.py (new)	—	66.67%	—
src/a2a/server/routes/jsonrpc_dispatcher.py (new)	—	85.78%	—
src/a2a/server/routes/jsonrpc_routes.py (new)	—	66.67%	—
Total	91.45%	91.38%	🔴 -0.06%

Generated by coverage-comment.yml

gemini-code-assist

Code Review

This pull request is a significant refactoring that removes the framework-specific A2AFastAPIApplication and A2AStarletteApplication in favor of a more modular approach using JsonRpcRoutes and AgentCardRoutes. This improves decoupling from web frameworks and increases flexibility. The changes are well-executed across the application and test suite. However, I've found a critical issue where a test file seems to have been missed in the refactoring, causing it to break. I've also noted some areas where test coverage might have been unintentionally reduced. Additionally, there are a few minor suggestions for improving code style and clarity.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

guglielmo-san · 2026-03-20T08:44:30Z

gemini-code-assist

Code Review

The pull request successfully refactors the JSON-RPC server implementation to use Starlette route-based endpoints, replacing the previous application wrappers. This change streamlines the architecture by introducing dedicated JsonRpcRoutes and AgentCardRoutes classes, which are then integrated directly into the main FastAPI/Starlette application. The removal of old application wrapper files and corresponding imports across the codebase is consistent with the refactoring goal. However, there are a couple of areas that could be improved for better encapsulation and explicit handling of request constraints.

ishymko

Revoke

…_json_rpc_server' into guglielmoc/refactor_json_rpc_server

🤖 I have created a release *beep* *boop* --- ## [1.0.0-alpha.1](v1.0.0-alpha.0...v1.0.0-alpha.1) (2026-04-10) ### ⚠ BREAKING CHANGES * **client:** make ClientConfig.push_notification_config singular ([#955](#955)) * **client:** reorganize ClientFactory API ([#947](#947)) * **server:** add build_user function to DefaultContextBuilder to allow A2A user creation customization ([#925](#925)) * **client:** remove `ClientTaskManager` and `Consumers` from client ([#916](#916)) * **server:** migrate from Application wrappers to Starlette route-based endpoints for rest ([#892](#892)) * **server:** migrate from Application wrappers to Starlette route-based endpoints for jsonrpc ([#873](#873)) ### Features * A2A Version Header validation on server side. ([#865](#865)) ([b261ceb](b261ceb)) * Add GetExtendedAgentCard Support to RequestHandlers ([#919](#919)) ([2159140](2159140)) * Add support for more Task Message and Artifact fields in the Vertex Task Store ([#936](#936)) ([605fa49](605fa49)) * Create EventQueue interface and make tap() async. ([#914](#914)) ([9ccf99c](9ccf99c)), closes [#869](#869) * EventQueue - unify implementation between python versions ([#877](#877)) ([7437b88](7437b88)), closes [#869](#869) * EventQueue is now a simple interface with single enqueue_event method. ([#944](#944)) ([f0e1d74](f0e1d74)) * Implementation of DefaultRequestHandlerV2 ([#933](#933)) ([462eb3c](462eb3c)), closes [#869](#869) * InMemoryTaskStore creates a copy of Task by default to make it consistent with database task stores ([#887](#887)) ([8c65e84](8c65e84)), closes [#869](#869) * merge metadata of new and old artifact when append=True ([#945](#945)) ([cc094aa](cc094aa)) * **server:** add async context manager support to EventQueue ([#743](#743)) ([f68b22f](f68b22f)) * **server:** validate presence according to `google.api.field_behavior` annotations ([#870](#870)) ([4586c3e](4586c3e)) * Simplify ActiveTask.subscribe() ([#958](#958)) ([62e5e59](62e5e59)) * Support AgentExectuor enqueue of a Task object. ([#960](#960)) ([12ce017](12ce017)) * Support Message-only simplified execution without creating Task ([#956](#956)) ([354fdfb](354fdfb)) * Unhandled exception in AgentExecutor marks task as failed ([#943](#943)) ([4fc6b54](4fc6b54)) ### Bug Fixes * Add `packaging` to base dependencies ([#897](#897)) ([7a9aec7](7a9aec7)) * **client:** do not mutate SendMessageRequest in BaseClient.send_message ([#949](#949)) ([94537c3](94537c3)) * fix `athrow()` RuntimeError on streaming responses ([#912](#912)) ([ca7edc3](ca7edc3)) * fix docstrings related to `CallContextBuilder` args in constructors and make ServerCallContext mandatory in `compat` folder ([#907](#907)) ([9cade9b](9cade9b)) * fix error handling for gRPC and SSE streaming ([#879](#879)) ([2b323d0](2b323d0)) * fix JSONRPC error handling ([#957](#957)) ([6c807d5](6c807d5)) * fix REST error handling ([#893](#893)) ([405be3f](405be3f)) * handle SSE errors occurred after stream started ([#894](#894)) ([3a68d8f](3a68d8f)) * remove the use of deprecated types from VertexTaskStore ([#889](#889)) ([6d49122](6d49122)) * Remove unconditional SQLAlchemy dependency from SDK core ([#898](#898)) ([ab762f0](ab762f0)), closes [#883](#883) * remove unused import and request for FastAPI in pyproject ([#934](#934)) ([fe5de77](fe5de77)) * replace stale entry in a2a.types.__all__ with actual import name ([#902](#902)) ([05cd5e9](05cd5e9)) * wrong method name for ExtendedAgentCard endpoint in JsonRpc compat version ([#931](#931)) ([5d22186](5d22186)) ### Documentation * add Database Migration Documentation ([#864](#864)) ([fd12dff](fd12dff)) ### Miscellaneous Chores * release 1.0.0-alpha.1 ([a61f6d4](a61f6d4)) ### Code Refactoring * **client:** make ClientConfig.push_notification_config singular ([#955](#955)) ([be4c5ff](be4c5ff)) * **client:** remove `ClientTaskManager` and `Consumers` from client ([#916](#916)) ([97058bb](97058bb)), closes [#734](#734) * **client:** reorganize ClientFactory API ([#947](#947)) ([01b3b2c](01b3b2c)) * **server:** add build_user function to DefaultContextBuilder to allow A2A user creation customization ([#925](#925)) ([2648c5e](2648c5e)) * **server:** migrate from Application wrappers to Starlette route-based endpoints for jsonrpc ([#873](#873)) ([734d062](734d062)) * **server:** migrate from Application wrappers to Starlette route-based endpoints for rest ([#892](#892)) ([4be2064](4be2064)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

wip

befb4f6

gemini-code-assist Bot reviewed Mar 19, 2026

View reviewed changes

guglielmo-san and others added 2 commits March 19, 2026 21:10

Update src/a2a/server/routes/agent_card_routes.py

71a9285

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

fix suggestions

fee5d5e

guglielmo-san changed the title ~~refactor(server)!: remove jsonrpc server support for Starlette and FastApi~~ refactor(server)!: migrate from Application wrappers to Starlette route-based endpoints for jsonrpc Mar 20, 2026

guglielmo-san marked this pull request as ready for review March 20, 2026 08:12

guglielmo-san requested a review from a team as a code owner March 20, 2026 08:12

guglielmo-san added 2 commits March 20, 2026 08:19

revert test

23e149d

revert wrong changes

b3c201e

guglielmo-san requested a review from ishymko March 20, 2026 08:27

gemini-code-assist Bot reviewed Mar 20, 2026

View reviewed changes

Comment thread src/a2a/server/routes/jsonrpc_dispatcher.py

Comment thread src/a2a/server/routes/jsonrpc_routes.py Outdated

guglielmo-san added 2 commits March 20, 2026 08:52

make method public

3c962e2

Merge branch '1.0-dev' into guglielmoc/refactor_json_rpc_server

04dd40b

ishymko approved these changes Mar 20, 2026

View reviewed changes

Comment thread src/a2a/server/routes/__init__.py Outdated

Comment thread src/a2a/server/routes/agent_card_routes.py

Comment thread src/a2a/server/routes/jsonrpc_routes.py Outdated

ishymko reviewed Mar 20, 2026

View reviewed changes

guglielmo-san added 6 commits March 20, 2026 16:35

fix

921651b

Merge branch '1.0-dev' into guglielmoc/refactor_json_rpc_server

128bda3

linter

d48a3c2

Merge remote-tracking branch 'refs/remotes/origin/guglielmoc/refactor…

205078b

…_json_rpc_server' into guglielmoc/refactor_json_rpc_server

fix

df96884

Merge branch '1.0-dev' into guglielmoc/refactor_json_rpc_server

324da5e

guglielmo-san enabled auto-merge (squash) March 23, 2026 16:04

guglielmo-san merged commit 734d062 into a2aproject:1.0-dev Mar 23, 2026
9 checks passed

a2a-bot mentioned this pull request Mar 23, 2026

chore(1.0-dev): release 1.0.0-alpha.1 #861

Merged

guglielmo-san mentioned this pull request Mar 30, 2026

feat(server): allow standard FastAPI Security in routes #785

Closed

4 tasks

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

refactor(server)!: migrate from Application wrappers to Starlette route-based endpoints for jsonrpc - #873

refactor(server)!: migrate from Application wrappers to Starlette route-based endpoints for jsonrpc#873
guglielmo-san merged 13 commits into
a2aproject:1.0-devfrom
guglielmo-san:guglielmoc/refactor_json_rpc_server

guglielmo-san commented Mar 19, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Mar 19, 2026

Uh oh!

github-actions Bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guglielmo-san commented Mar 20, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ishymko left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

guglielmo-san commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

gemini-code-assist Bot commented Mar 19, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Code Coverage (vs 1.0-dev)

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guglielmo-san commented Mar 20, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ishymko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

guglielmo-san commented Mar 19, 2026 •

edited

Loading

github-actions Bot commented Mar 19, 2026 •

edited

Loading

🧪 Code Coverage (vs `1.0-dev`)