{{ message }}
Repository navigation
fix: Ensure metadata propagation for Task ToProto and FromProto conversion - #557
Merged
Merged
Conversation
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly adds metadata propagation from types.Task to a2a_pb2.Task. While the change itself is correct, it is incomplete. The reverse conversion in FromProto.task is missing the metadata field, which will lead to data loss during a round-trip conversion. Additionally, this new functionality is not covered by unit tests. I've added a comment regarding the missing test coverage. To make this fix complete, please also update FromProto.task to handle metadata and add a round-trip test case to verify the behavior.
holtskinner
changed the title
types.Task to a2a_pb2.Task in proto_utils.py
…_conversion_roundtrip`.
sokoliva
changed the title
types.Task to a2a_pb2.Task in proto_utils.pyTask ToProto and FromProto conversion
… to improve readability.
lkawka
approved these changes
Nov 21, 2025
sokoliva
pushed a commit
that referenced
this pull request
Nov 21, 2025
🤖 I have created a release *beep* *boop* --- ## [0.3.16](v0.3.15...v0.3.16) (2025-11-21) ### Bug Fixes * Ensure metadata propagation for `Task` `ToProto` and `FromProto` conversion ([#557](#557)) ([fc31d03](fc31d03)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
metadatadictionary is now correctly propagated in both theToProto(types.Task to a2a_pb2.Task) andFromProto(a2a_pb2.Task to types.Task) conversion utilities.Fixes #541 🦕