{{ message }}
Repository navigation
refactor: extract AgentExecutorProducer_v0_3 into separate test module - #890
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors several domain classes in the compat-0.3 package from standard classes to Java records, updates associated mappers and tests to use record accessors, and introduces a common test infrastructure module. The review feedback highlights several areas for improvement, including removing redundant null checks that are now covered by record constructors, ensuring immutability for lists, and using proper annotations for CDI proxying requirements.
kabir
force-pushed
the
jakarta-fixes-2
branch
3 times, most recently
from
May 26, 2026 15:30
5d9c42b to
518865b
Compare
kabir
marked this pull request as ready for review
May 26, 2026 15:30
kabir
force-pushed
the
jakarta-fixes-2
branch
3 times, most recently
from
May 27, 2026 10:36
b99d4be to
0d7a646
Compare
Move AgentExecutorProducer_v0_3 from compat-0.3/server-conversion test-jar into a new compat-0.3/tests/server-common module to fix CDI ambiguous dependency errors in downstream consumers that depend on both the v0.3 and v1.0 test-jars. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Avoiding creating an empty jar file
salaboy
pushed a commit
to salaboy/a2a-java
that referenced
this pull request
Jun 19, 2026
a2aproject#890) * refactor: extract AgentExecutorProducer_v0_3 into separate test module Move AgentExecutorProducer_v0_3 from compat-0.3/server-conversion test-jar into a new compat-0.3/tests/server-common module to fix CDI ambiguous dependency errors in downstream consumers that depend on both the v0.3 and v1.0 test-jars. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Avoiding creating an empty jar file Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com> --------- Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Emmanuel Hugonnet <ehugonne@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move AgentExecutorProducer_v0_3 from compat-0.3/server-conversion
test-jar into a new compat-0.3/tests/server-common module to fix CDI
ambiguous dependency errors in downstream consumers that depend on both
the v0.3 and v1.0 test-jars.
#889 should be merged before this