{{ message }}
Repository navigation
chore: Upgrading NullAway to 0.13.4 and error prone to 2.49.0 - #840
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the versions of Error Prone and NullAway and removes several unused imports. The feedback suggests improving the NullAway configuration by adding the CustomInitializerAnnotations option for @PostConstruct, which would reduce the need for manual suppressions. Furthermore, it is recommended to address initialization warnings by using constructor-based dependency injection rather than applying @SuppressWarnings("NullAway.Init") to methods.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
kabir
approved these changes
Apr 30, 2026
kabir
left a comment
kabir
left a comment
Collaborator
There was a problem hiding this comment.
Should be good once CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.