{{ message }}
Repository navigation
fix: Use correct HTTP status code for PushNotificationNotSupportedError - #758
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Code Review
This pull request changes the HTTP status code for PushNotificationNotSupportedError from 501 (Not Implemented) to 400 (Bad Request). This is a more appropriate mapping, as attempting to use a feature that the agent has explicitly declared as unsupported can be considered a client error. The change is correctly implemented in RestHandler.java, and the corresponding test in RestHandlerTest.java has been updated to reflect the new expected status code. The changes are correct and I have no further suggestions.
jmesnil
approved these changes
Mar 18, 2026
salaboy
pushed a commit
to salaboy/a2a-java
that referenced
this pull request
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #748 🦕