Repository navigation
chore: Next Snapshot - #752
Conversation
There was a problem hiding this comment.
Code Review
This pull request prepares for the 1.0.0.Alpha4 release by updating the project version across all modules. The changes are consistent for a release. I've provided a couple of suggestions to improve the maintainability of the versioning process for future releases, one for the jbang script and another for the Maven modules.
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client:1.0.0.Beta1-SNAPSHOT | ||
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client-transport-jsonrpc:1.0.0.Beta1-SNAPSHOT | ||
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client-transport-grpc:1.0.0.Beta1-SNAPSHOT | ||
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client-transport-rest:1.0.0.Beta1-SNAPSHOT | ||
| //DEPS org.a2aproject.sdk:a2a-java-sdk-opentelemetry-client:1.0.0.Beta1-SNAPSHOT | ||
| //DEPS org.a2aproject.sdk:a2a-java-sdk-opentelemetry-client-propagation:1.0.0.Beta1-SNAPSHOT |
There was a problem hiding this comment.
To simplify version management in this jbang script, you could use the project's Bill of Materials (BOM). This would reduce the number of lines to update for each release from six to one. You can replace the individual dependencies with a BOM import and version-less dependency declarations.
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client:1.0.0.Beta1-SNAPSHOT | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client-transport-jsonrpc:1.0.0.Beta1-SNAPSHOT | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client-transport-grpc:1.0.0.Beta1-SNAPSHOT | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client-transport-rest:1.0.0.Beta1-SNAPSHOT | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-opentelemetry-client:1.0.0.Beta1-SNAPSHOT | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-opentelemetry-client-propagation:1.0.0.Beta1-SNAPSHOT | |
| //BOM org.a2aproject.sdk:a2a-java-sdk-extras-bom:1.0.0.Alpha4 | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client-transport-jsonrpc | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client-transport-grpc | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-client-transport-rest | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-opentelemetry-client | |
| //DEPS org.a2aproject.sdk:a2a-java-sdk-opentelemetry-client-propagation |
There was a problem hiding this comment.
For future releases, consider using a tool like the versions-maven-plugin to automate version updates across all pom.xml files. This can reduce manual effort and the risk of inconsistencies. For example, running mvn versions:set -DnewVersion=... would update the version in all modules. Note that this would not update the jbang script, which would still require separate attention.
Main aim is to make sure the automated Maven deploy works with the new groupId

Main aim is to make sure the automated Maven deploy works with the new groupId