iframe-proxy

neo1027144-creator · 2026-03-12T19:24:00Z

Add unit tests for DeviceCodeOAuthFlow record class.

Test cases:

Construction with all fields populated
Null refreshUrl (optional field)
Empty scopes map
Null validation for required fields (deviceAuthorizationUrl, tokenUrl, scopes)
Record equality and hashCode consistency

Follows the same testing patterns as FileWithBytesTest.

Fixes #607

gemini-code-assist · 2026-03-12T19:24:12Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness of the DeviceCodeOAuthFlow record by introducing a dedicated suite of unit tests. These tests validate the record's behavior across various construction scenarios, ensuring correct handling of both required and optional fields, proper null validation, and consistent equals and hashCode implementations. This work directly contributes to the stability and reliability of the OAuth flow mechanisms.

Highlights

Unit Test Introduction: Added comprehensive unit tests for the DeviceCodeOAuthFlow record class.
Test Coverage: Included test cases for full field population, null refreshUrl handling, empty scopes, null validation for required fields (deviceAuthorizationUrl, tokenUrl, scopes), and equals/hashCode consistency.
Pattern Adherence: Followed established testing patterns, similar to FileWithBytesTest.
Issue Resolution: Addressed and fixed issue [Bug]: Missing tests for DeviceCodeOAuthFlow #607.

Activity

The pull request was created, and no human activity has occurred yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds a comprehensive set of unit tests for the DeviceCodeOAuthFlow record class. The tests cover construction, null validation for required fields, handling of optional fields, and record equality. The implementation is solid. I've provided a couple of suggestions to make the tests even more robust: one to enhance the assertions in the empty scopes test for better consistency, and another to expand the equality test to include inequality checks, which will provide more complete validation of the record's behavior.

ehsavoie · 2026-04-01T08:46:24Z

@neo1027144-creator can you please fix the gemini code review

neo1027144-creator · 2026-04-01T12:19:36Z

Sorry for the delayed response — I've just addressed the review feedback.
Thanks for the reminder!

@ehsavoie

neo1027144-creator · 2026-04-01T12:26:57Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces unit tests for the DeviceCodeOAuthFlow class, covering object construction, parameter validation, and basic equality. The feedback suggests enhancing the test suite by adding a test for the immutability of the scopes map to ensure defensive copying and expanding the equality and hash code tests to include more comprehensive edge cases such as type mismatches and null checks.

neo1027144-creator · 2026-04-01T13:12:52Z

/gemini review

gemini-code-assist

Code Review

This pull request ensures the immutability of the DeviceCodeOAuthFlow record by implementing a defensive copy of the scopes map during construction. It also introduces a new test class, DeviceCodeOAuthFlowTest, which provides comprehensive coverage for valid and invalid construction scenarios, equality checks, and immutability verification. I have no feedback to provide as no review comments were present.

ehsavoie · 2026-04-09T15:19:30Z

@@ -33,5 +33,6 @@ public record DeviceCodeOAuthFlow(String deviceAuthorizationUrl, String tokenUrl
        Assert.checkNotNullParam("deviceAuthorizationUrl", deviceAuthorizationUrl);
        Assert.checkNotNullParam("tokenUrl", tokenUrl);
        Assert.checkNotNullParam("scopes", scopes);
+        scopes = Map.copyOf(scopes);


I don't think this 'work' but public Map<String, String> scopes() should be overriden to return Map.copyOf(scopes)

ehsavoie · 2026-04-16T15:02:49Z

@neo1027144-creator Would you mind rebasing and fixing my comment.

Test cases: - Construction with all fields populated - Null refreshUrl (optional field) - Empty scopes map with full field assertions - Null validation for required fields (deviceAuthorizationUrl, tokenUrl, scopes) - Record equality, hashCode consistency, and inequality edge cases - Scopes map immutability (defensive copy via Map.copyOf) Also fix: override scopes() to return Map.copyOf(scopes) for defensive copying Fixes a2aproject#607

neo1027144-creator · 2026-04-19T06:58:28Z

Hi @ehsavoie, I've rebased onto the latest main and addressed your review comment. I've overridden scopes() to return Map.copyOf(scopes) as you suggested. I also kept the Map.copyOf(scopes) in the compact constructor to ensure the record's internal field is disconnected from the original mutable map reference (without this, external modifications to the original map would still be visible through the overridden accessor). Thanks for the review!

ehsavoie · 2026-04-19T13:51:58Z

gemini-code-assist Bot reviewed Mar 12, 2026

View reviewed changes

Comment thread spec/src/test/java/io/a2a/spec/DeviceCodeOAuthFlowTest.java Outdated

Comment thread spec/src/test/java/io/a2a/spec/DeviceCodeOAuthFlowTest.java Outdated

neo1027144-creator force-pushed the issue-607 branch from 1da4049 to e751b3f Compare April 1, 2026 12:15

gemini-code-assist Bot reviewed Apr 1, 2026

View reviewed changes

Comment thread spec/src/test/java/org/a2aproject/sdk/spec/DeviceCodeOAuthFlowTest.java

Comment thread spec/src/test/java/org/a2aproject/sdk/spec/DeviceCodeOAuthFlowTest.java

neo1027144-creator force-pushed the issue-607 branch from 355301e to ac9f5b3 Compare April 1, 2026 13:10

gemini-code-assist Bot reviewed Apr 1, 2026

View reviewed changes

ehsavoie reviewed Apr 9, 2026

View reviewed changes

neo1027144-creator force-pushed the issue-607 branch from ac9f5b3 to 376cb26 Compare April 19, 2026 06:58

ehsavoie approved these changes Apr 20, 2026

View reviewed changes

ehsavoie merged commit c7e04c6 into a2aproject:main May 5, 2026
9 checks passed

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

neo1027144-creator commented Mar 12, 2026

Uh oh!

gemini-code-assist Bot commented Mar 12, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

ehsavoie commented Apr 1, 2026

Uh oh!

neo1027144-creator commented Apr 1, 2026

Uh oh!

neo1027144-creator commented Apr 1, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

neo1027144-creator commented Apr 1, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

ehsavoie Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

ehsavoie commented Apr 16, 2026

Uh oh!

neo1027144-creator commented Apr 19, 2026

Uh oh!

ehsavoie commented Apr 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants