{{ message }}
Repository navigation
fix: make InMemoryPushNotificationConfigStore thread-safe - #1057
Merged
ehsavoie merged 3 commits intoAug 14, 2026
Merged
Conversation
Use ConcurrentHashMap with compute()/computeIfPresent() for atomic per-key operations and store immutable list snapshots via List.copyOf(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kabir Khan <kkhan@redhat.com>
kabir
force-pushed
the
fix/push-config-store-thread-safety
branch
from
August 12, 2026 09:40
e595a77 to
b36396f
Compare
…n InMemoryPushNotificationConfigStore - add concurrent limit-enforcement test using CyclicBarrier to verify compute() atomicity when two threads race for the last config slot - drop unnecessary ArrayList copy when pageSize <= 0 since stored values are already immutable List.copyOf() snapshots Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
test(server-common): add concurrency test and remove redundant copy in InMemoryPushNotificationConfigStore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ConcurrentHashMap with compute()/computeIfPresent() for atomic per-key operations and store immutable list snapshots via List.copyOf().
Follows up on #1044