iframe-proxy

chandrasekharan-zipstack · 2026-05-27T10:47:21Z

Summary

Three tightly-coupled fixes prompted by the broken v1.3 / v1.4 release dispatches today.

1. Lint failures in `src/unstract/clone/`

Run 26506031574 failed with 10 E501 (line-too-long > 88) violations across the new clone subpackage. These were not caught at PR time because the PR-gate workflow (test.yml) only ran pytest. Reworded the offending lines (no behavioral change) and added ruff check src/ to test.yml so lint regressions block at PR time.

2. Release workflow ordering

main.yml performed version bump → commit to main → push tag → create GH release before running lint/tests/build. So a lint failure left main with a phantom version bump and an orphaned GitHub release (v1.4.0, deleted out-of-band as part of this work).

New ordering — verification first, side-effects second:

Compute new version + write to __init__.py locally (no commit)
Verify version match
Lint (ruff check src/)
Tests (pytest)
Build (uv build)
Only on success: commit bump, push to main, tag, push tag, create GH release
uv publish to PyPI

3. Version revert: `1.4.0 → 1.2.1`

Run #1 (failed at tag step but succeeded at commit-push) and run #2 (created v1.4.0 then failed at lint) left main at 1.4.0 with no corresponding published artifact. Reverted so the next manual trigger produces the intended v1.3.0.

Test plan

uv run ruff check src/ passes locally
uv run pytest tests/ — 167 passed locally
gh release delete v1.4.0 + git push --delete origin v1.4.0 done out-of-band
CI (this PR) — new Lint (ruff) step on test.yml runs green
After merge: trigger main.yml manually with minor bump → expect clean v1.3.0 release end-to-end

🤖 Generated with Claude Code

…eanup Fixes the issues exposed when the v1.3/v1.4 dispatches blew up: - 10 E501 line-too-long violations in src/unstract/clone/ (caused the lint failure in release run 26506031574) - Release workflow did commit-bump + push-to-main + tag + GH release BEFORE running lint/tests/build, so a lint failure left main with a phantom version bump and an orphan release. Lint/tests/build now run against the bumped __init__.py in-place, and only on success does the workflow commit, tag, release, and PyPI-publish. - Add ruff to the PR gate (test.yml) so lint regressions block at PR time instead of release time. - Revert __version__ from 1.4.0 to 1.2.1 so the next manual trigger produces the intended v1.3.0 cleanly. Orphan v1.4.0 tag + GitHub release have been deleted out-of-band. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

greptile-apps · 2026-05-27T10:50:04Z

Greptile Summary

This PR addresses the broken v1.3/v1.4 release process by restructuring main.yml so all verification (lint, tests, build, PyPI publish) runs before any git side-effects (commit, tag, GitHub release), adds ruff check src/ to test.yml so lint failures block at PR time, reverts __version__ to 1.2.1, and fixes E501 line-length violations across the clone subpackage.

Workflow reorder (main.yml): Version is now bumped locally first, then verified, linted, tested, built, and published to PyPI before the commit/tag/release are written — ensuring a lint or test failure can no longer leave a phantom commit or orphaned GitHub release on main.
PR gate (test.yml): Ruff linting is now a required check alongside pytest, running against both Python 3.11 and 3.12 matrix entries so E501 regressions are caught before merge.
Lint fixes (src/unstract/clone/): Eight string literals shortened to comply with the 88-character line limit; no behavioral changes.

Confidence Score: 5/5

Safe to merge — the workflow reorder is a clear improvement, lint fixes are cosmetic, and the version revert is intentional and correct.

The release workflow is significantly more resilient than before: all validation runs before any git mutation, and the only remaining trade-off (PyPI publish preceding the git commit) is explicitly acknowledged in a code comment. The clone file changes are pure string truncations with zero runtime impact. The version revert is deliberate and well-explained.

.github/workflows/main.yml is the only file with meaningful logic changes; the open concerns from prior review threads (dispatch guard and publish-before-tag ordering) are already tracked there.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant FS as File System
    participant PyPI as PyPI (Trusted Publisher)
    participant Repo as Git / GitHub

    GH->>FS: Compute new version (bump __init__.py locally, no commit)
    GH->>FS: Verify version update (file vs step output)
    GH->>GH: Lint (ruff check src/)
    GH->>GH: Tests (pytest)
    GH->>GH: Build (uv build)
    GH->>PyPI: Publish (uv publish via OIDC)
    Note over PyPI: Point of no return — artifact is live
    GH->>Repo: git commit version bump + push to main
    GH->>Repo: git tag vX.Y.Z + push tag
    GH->>Repo: gh release create vX.Y.Z
    GH->>GH: Success message

_{Reviews (2): Last reviewed commit: "fix(ci): publish to PyPI before tag/rele..." | Re-trigger Greptile}

… guards Address greptile P1 + P2: - P1: uv publish now runs before commit/tag/release. PyPI is the only irreversible step, so if a later git/release call fails the artifact is the source of truth and the metadata can be retried. - P2: workflow only triggers on workflow_dispatch (see top-level `on:`), so the per-step `if: github.event_name == 'workflow_dispatch'` guards were redundant and inconsistent (only on bookends, not lint/test/build). Removed them — any future trigger addition should be a deliberate per-step decision. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

chandrasekharan-zipstack requested a review from jaseemjaskp May 27, 2026 10:49

chandrasekharan-zipstack self-assigned this May 27, 2026

greptile-apps Bot reviewed May 27, 2026

View reviewed changes

Comment thread .github/workflows/main.yml

Comment thread .github/workflows/main.yml Outdated

jaseemjaskp approved these changes May 27, 2026

View reviewed changes

chandrasekharan-zipstack merged commit 35f985d into main May 27, 2026
3 checks passed

chandrasekharan-zipstack deleted the fix/release-workflow-lint-and-ordering branch May 27, 2026 10:55

chandrasekharan-zipstack mentioned this pull request May 27, 2026

UN-3479 [FIX] release workflow: install --all-extras to match PR gate #18

Merged

2 tasks

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

UN-3479 [FIX] release workflow: validate before tag/publish + lint cleanup - #17

UN-3479 [FIX] release workflow: validate before tag/publish + lint cleanup#17
chandrasekharan-zipstack merged 2 commits into
mainfrom
fix/release-workflow-lint-and-ordering

chandrasekharan-zipstack commented May 27, 2026

Uh oh!

greptile-apps Bot commented May 27, 2026 •

edited

Loading

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

chandrasekharan-zipstack commented May 27, 2026

Summary

1. Lint failures in src/unstract/clone/

2. Release workflow ordering

3. Version revert: 1.4.0 → 1.2.1

Test plan

Uh oh!

greptile-apps Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

1. Lint failures in `src/unstract/clone/`

3. Version revert: `1.4.0 → 1.2.1`

greptile-apps Bot commented May 27, 2026 •

edited

Loading