{{ message }}
Repository navigation
Results 2.0 - #970
Merged
Merged
Results 2.0#970
Conversation
Fix eslint warnings
Add direct beacon healing checklist item
… good Use average requirement performance for rule performance to be less punishing
[Mistweaver Monk] SotC Update and Add in Defensive CD Usage to Checklist
…onfig than a feature
…ew (and add isOnGCD props to Abilities in prep of a small ABC refactor)
[Beast Mastery] Initial Beast Mastery
[Unholy Death Knight] Checklist support
[Beast Mastery] Checklist update + Dire Frenzy and AotW modules
# Conflicts: # src/Parser/Mage/Fire/Modules/Features/HotStreak.js
anom0ly
previously approved these changes
Dec 24, 2017
anom0ly
left a comment
anom0ly
left a comment
Member
There was a problem hiding this comment.
I went through all of the core components. I think all of this looks good for a first release. The few things that are missing, I think we have identified as issues, mainly the explanation of the bars (ex. where lower numbers fill the bar up).
I didn't review the individual spec checklists / changes, as a FYI.
Add the checklist announcement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge yet please. TLDR: checkout, review, give code feedback, add your own spec
This is a rework of the results page. There are quite a few things left to do, but the main parts are in place and working. I'd like to focus this PR on reviews about the checklist, how it's defined, how it works, what it includes, my choice of texts, etc.
The goal of this review is to gather opinions and prepare the branch for checklists for other specs (I'd like to support more than just the Holy Paladin checklist when merging this, going to try to do a "big announcement" since I believe this to be the biggest change since the introduction of suggestions).
When reviewing I recommend checking out this branch and running a Holy Paladin log through it. See instructions at the bottom of this PR.