{{ message }}
Repository navigation
Updated old files + added Shield Block module. - #367
Merged
Merged
Conversation
MartijnHols
approved these changes
Sep 23, 2017
Member
There was a problem hiding this comment.
Naming style for these is ShieldBlock.
| on_byPlayer_removebuff(event) { | ||
| const spellId = event.ability.guid; | ||
| if (SPELLS.SHIELD_BLOCK_BUFF.id === spellId) { | ||
| this.lastShield_BlockBuffApplied = 0; |
Member
There was a problem hiding this comment.
Unsetting a value to NULL would be cleaner, 0 could be a valid value (although it would never happen probably), while NULL is clear.
| on_toPlayer_damage(event) { | ||
| // Physical | ||
| if (event.ability.type === 1) { | ||
| if (this.lastShield_BlockBuffApplied > 0) { |
Member
There was a problem hiding this comment.
Can be replaced with this.combatants.selected.hasBuff(SPELLS.SHIELD_BLOCK_BUFF.id).
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated older files to remove unused & unnecessary lines, added lines for Protection Warrior into the Available Configs file, created a module that shows information revolving around Shield Block usage (total hits mitigated, total hits unmitigated, etc).