Add feature flag for wide arithmetic by stevenfontanella · Pull Request #8639 · WebAssembly/binaryen · GitHub
Skip to content

Add feature flag for wide arithmetic#8639

Merged
stevenfontanella merged 1 commit intomainfrom
wide-arithmetic-features
Apr 23, 2026
Merged

Add feature flag for wide arithmetic#8639
stevenfontanella merged 1 commit intomainfrom
wide-arithmetic-features

Conversation

@stevenfontanella
Copy link
Copy Markdown
Member

@stevenfontanella stevenfontanella commented Apr 21, 2026

Part of #8544. Based on #8192.

@stevenfontanella stevenfontanella force-pushed the wide-arithmetic-features branch 6 times, most recently from 7f3617c to 8b5d54c Compare April 22, 2026 23:34
@stevenfontanella stevenfontanella changed the base branch from main to emit-all-features April 23, 2026 00:14
@stevenfontanella stevenfontanella marked this pull request as ready for review April 23, 2026 00:14
@stevenfontanella stevenfontanella requested a review from a team as a code owner April 23, 2026 00:14
@stevenfontanella stevenfontanella requested review from kripken and removed request for a team April 23, 2026 00:14
stevenfontanella added a commit that referenced this pull request Apr 23, 2026
In #8639, the CI failed on Windows 11 because the total number of
features became 26 (0x1A), which is the EOF byte in Windows. Write to a
temp file to ensure that the file is read as binary. Resolves the CI in
the next PR.

Part of #8544.
Base automatically changed from emit-all-features to main April 23, 2026 04:57
@stevenfontanella stevenfontanella force-pushed the wide-arithmetic-features branch from 8b5d54c to 1891d2d Compare April 23, 2026 05:00
@stevenfontanella stevenfontanella merged commit fb9043e into main Apr 23, 2026
16 checks passed
@stevenfontanella stevenfontanella deleted the wide-arithmetic-features branch April 23, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants