Prbhav by Prbhav-Attray · Pull Request #2993 · WeMakeDevs/github-tutorial · GitHub
Skip to content

Prbhav#2993

Open
Prbhav-Attray wants to merge 1 commit into
WeMakeDevs:mainfrom
Prbhav-Attray:prbhav
Open

Prbhav#2993
Prbhav-Attray wants to merge 1 commit into
WeMakeDevs:mainfrom
Prbhav-Attray:prbhav

Conversation

@Prbhav-Attray

@Prbhav-Attray Prbhav-Attray commented Mar 16, 2024

Copy link
Copy Markdown

Summary by CodeRabbit

  • Documentation
    • Updated README with a note on the decision to learn Git and GitHub by "prbhav attray."

@coderabbitai

coderabbitai Bot commented Mar 16, 2024

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 569c579 and e3a85ff.
Files selected for processing (1)
  • README.md (1 hunks)
Additional comments: 1
README.md (1)
  • 5-8: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The static analysis tool suggests a possible spelling mistake with "WeMakeDevs". Assuming "WeMakeDevs" is the intended name, this can be ignored. However, consider clarifying or expanding the acronym "OP" if it might not be universally understood by all readers.

Consider adding a footnote or a brief explanation for "OP" if it's not a widely recognized term within your community.

Comment thread README.md
@@ -5,3 +5,4 @@
- I love MLH
- More power to kunal. love the work which your are doing for the community.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a grammatical error in this sentence. "Your" should be replaced with "you're" to correctly convey the meaning.

- More power to kunal. love the work which your are doing for the community.
+ More power to Kunal. Love the work which you're doing for the community.

Also, capitalize "Kunal" and "Love" to maintain consistency and proper noun capitalization.


Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- More power to kunal. love the work which your are doing for the community.
More power to Kunal. Love the work which you're doing for the community.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 569c579 and cdfc040.
Files selected for processing (1)
  • README.md (1 hunks)
Additional comments: 1
README.md (1)
  • 6-6: The existing comment regarding grammatical errors and capitalization is still valid and should be addressed:
- More power to kunal. love the work which your are doing for the community.
+ More power to Kunal. Love the work which you're doing for the community.

Comment thread README.md
- I love MLH
- More power to kunal. love the work which your are doing for the community.
- Anirudh Sharma finds the Community Classroom initiative really great!
- So finally i (prbhav attray) decided to learn git and github and guess what , i am learning it from the best!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line added by "prbhav attray" contains several issues that need correction:

  • The official name of the software platform should be spelled with a capital "H" in "GitHub".
  • Ensure proper spacing after commas and use uppercase "I" for personal pronouns.
  • Consider correcting the spelling of "prbhav attray" if it's a typo.

Here's a suggested correction:

- So finally i (prbhav attray) decided to learn git and github and guess what , i am learning it from the best!
+ So finally I (Prabhav Attray) decided to learn Git and GitHub, and guess what, I am learning it from the best!

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant