Rohan added a message by rohanh504 · Pull Request #2986 · WeMakeDevs/github-tutorial · GitHub
Skip to content

Rohan added a message#2986

Open
rohanh504 wants to merge 2 commits into
WeMakeDevs:mainfrom
rohanh504:rohan
Open

Rohan added a message#2986
rohanh504 wants to merge 2 commits into
WeMakeDevs:mainfrom
rohanh504:rohan

Conversation

@rohanh504

@rohanh504 rohanh504 commented Feb 21, 2024

Copy link
Copy Markdown

Summary by CodeRabbit

  • Documentation
    • Updated the attributions in the README to reflect the change from Kunal Kushwaha to Rohan Halder in praising the community.
  • Chores
    • Added a new file cities.txt listing the cities Delhi (repeated), Kolkata, and Mumbai.

@coderabbitai

coderabbitai Bot commented Feb 21, 2024

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 569c579 and f8efb61.
Files selected for processing (1)
  • README.md (1 hunks)
Additional comments: 2
README.md (2)
  • 3-3: Ensure that the change in attribution from Kunal Kushwaha to Rohan Halder accurately reflects the community's sentiments and is agreed upon by all parties involved. This change should also be consistent with the project's guidelines on attributions in the README.
  • 7-7: The message attributed to Rohan Halder about finding the Community Classroom initiative really great is a positive addition. However, ensure that this message aligns with the overall tone and content of the community section, and that it does not duplicate any existing messages.

Comment thread README.md

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition "- Rohan made this change" seems to be more of a change log entry rather than a piece of praise or a message about the community. Consider moving this type of content to a more appropriate section of the document, such as a change log or the PR description itself, to maintain the focus of the community section on messages of praise or significance.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f8efb61 and 2cd544c.
Files selected for processing (1)
  • cities.txt (1 hunks)
Additional comments: 1
cities.txt (1)
  • 1-2: The city "Delhi" is listed twice. If the intention is to have a unique list of cities, this might be an oversight. Could you clarify if the repetition is intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant